Skip to content

Commit

Permalink
Disable the shared-reviwers-signify group for now. (#25627)
Browse files Browse the repository at this point in the history
Due to dropseed/pullapprove#71 it's causing PRs to land
with an insufficient number of reviews.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Jul 8, 2023
1 parent a975380 commit 3933477
Showing 1 changed file with 14 additions and 8 deletions.
22 changes: 14 additions & 8 deletions .pullapprove.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,14 +144,20 @@ groups:
teams: [reviewers-samsung]
reviews:
request: 10
shared-reviewers-signify:
type: optional
conditions:
- files.include('*')
reviewers:
teams: [reviewers-signify]
reviews:
request: 10
# shared-reviewers-signify disabled for now, because the reviewers-signify
# team is empty and pullapprove seems to mis-handle that badly and treats
# _all_ reviewers as being in this group.
#
# See https://github.com/dropseed/pullapprove/issues/71
#
# shared-reviewers-signify:
# type: optional
# conditions:
# - files.include('*')
# reviewers:
# teams: [reviewers-signify]
# reviews:
# request: 10
shared-reviewers-silabs:
type: optional
conditions:
Expand Down

0 comments on commit 3933477

Please sign in to comment.