Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add identify support ot linux/all-cluster-app and fix initialization #10907

Merged
merged 2 commits into from Oct 26, 2021
Merged

Add identify support ot linux/all-cluster-app and fix initialization #10907

merged 2 commits into from Oct 26, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 25, 2021

Problem

Change overview

  • added identify support to linux/all-cluster-app
  • fix identify ctor / init

Testing

Teste with all-cluster-app and chip-device-ctrl.

@ghost ghost changed the title Bugfix/10859 identify time Bugfix identify time Oct 25, 2021
@github-actions
Copy link

github-actions bot commented Oct 25, 2021 •
edited
Loading

PR #10907: Size comparison from afd63a1 to 9b76e76

5 builds (for p6, qpg, telink)
platform target config section afd63a1 9b76e76 change % change
p6 lock-app default .bss 67208 67208 0 0.0
.data 2416 2416 0 0.0
.heap 963720 963720 0 0.0
.text 1125992 1125992 0 0.0
qpg lighting-app qpg6100+debug .bss 52456 52456 0 0.0
.data 1004 1004 0 0.0
.text 485048 485048 0 0.0
lock-app qpg6100+debug .bss 51400 51400 0 0.0
.data 960 960 0 0.0
.text 461188 461188 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149896 149896 0 0.0
telink lighting-app tlsr9518adk80d bss 69988 69988 0 0.0
noinit 33216 33216 0 0.0
text 457670 457670 0 0.0

Increases above 1.0% from afd63a1 to 9b76e76:

platform target config section afd63a1 9b76e76 change % change
linux all-clusters-app debug .init_array 512 520 8 1.6
15 builds (for efr32, k32w, linux)
platform target config section afd63a1 9b76e76 change % change
efr32 lighting-app BRD4161A .bss 113716 113716 0 0.0
.data 1752 1752 0 0.0
.text 735768 735768 0 0.0
lock-app BRD4161A .bss 111572 111572 0 0.0
.data 1712 1712 0 0.0
.text 714984 714984 0 0.0
window-app BRD4161A .bss 111884 111884 0 0.0
.data 1716 1716 0 0.0
.text 715812 715812 0 0.0
lighting-app BRD4161A+rpc .bss 130220 130220 0 0.0
.data 1852 1852 0 0.0
.text 723184 723184 0 0.0
k32w lock-app k32w061+debug .bss 69228 69228 0 0.0
.data 1864 1864 0 0.0
.text 515076 515076 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359556 359556 0 0.0
lighting-app k32w061+se05x+release .bss 78744 78744 0 0.0
.data 1900 1900 0 0.0
.text 613792 613792 0 0.0
linux all-clusters-app debug .bss 50192 50320 128 0.3
.data 978 978 0 0.0
.data.rel.ro 60448 60448 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 520 8 1.6
.rodata 134485 134517 32 0.0
.text 1353266 1354530 1264 0.1
chip-tool debug .bss 17712 17712 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94016 94016 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 207140 207140 0 0.0
.text 3618293 3618293 0 0.0
ota-provider-app debug .bss 37472 37472 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1023554 1023554 0 0.0
ota-requestor-app debug .bss 205728 205728 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25800 25800 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 128424 128424 0 0.0
.text 1142274 1142274 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599506 599506 0 0.0
tv-app debug .bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 57408 57408 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 151944 151944 0 0.0
.text 1454306 1454306 0 0.0
bridge-app debug+rpc .bss 51888 51888 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27112 27112 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109740 0 0.0
.text 1064085 1064085 0 0.0
lighting-app debug+rpc .bss 41208 41208 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53808 53808 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1262034 1262034 0 0.0
3 builds (for mbed)
platform target config section afd63a1 9b76e76 change % change
mbed lighting-app CY8CPROTO_062_4343W+release .bss 171092 171092 0 0.0
.data 5464 5464 0 0.0
.heap 859888 859888 0 0.0
.text 1219112 1219112 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 170012 170012 0 0.0
.data 5432 5432 0 0.0
.heap 861000 861000 0 0.0
.text 1197072 1197072 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
2 builds (for esp32)
platform target config section afd63a1 9b76e76 change % change
esp32 all-clusters-app c3devkit .dram0.bss 58272 58272 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 197936 197936 0 0.0
.flash.text 874314 874386 72 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60776 60776 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206696 206696 0 0.0
.flash.text 905471 905423 -48 -0.0
.iram0.text 125115 125115 0 0.0
10 builds (for nrfconnect)
platform target config section afd63a1 9b76e76 change % change
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112168 112168 0 0.0
rodata 97100 97100 0 0.0
text 577208 577208 0 0.0
lock-app nrf52840dk_nrf52840 bss 111240 111240 0 0.0
rodata 93500 93500 0 0.0
text 558696 558696 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111300 111300 0 0.0
rodata 94396 94396 0 0.0
text 561852 561852 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111236 111236 0 0.0
rodata 93476 93476 0 0.0
text 558488 558488 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520316 520316 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108408 108408 0 0.0
rodata 87876 87876 0 0.0
text 550400 550400 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113540 113540 0 0.0
rodata 92340 92340 0 0.0
text 506680 506680 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112612 112612 0 0.0
rodata 88760 88760 0 0.0
text 488160 488160 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440924 440924 0 0.0

@andy31415 andy31415 changed the title Bugfix identify time Add identify support ot linux/all-cluster-app and fix initialization Oct 25, 2021
@andy31415
Copy link
Contributor

@eve-cxrp - merge conflicts

@ghost
Copy link
Author

ghost commented Oct 26, 2021

@andy31415 i don't see any conflicts?

@franck-apple franck-apple added this to the Test Event 7 milestone Oct 26, 2021
@woody-apple woody-apple merged commit aea917b into project-chip:master Oct 26, 2021
@bzbarsky-apple bzbarsky-apple mentioned this pull request Oct 27, 2021
Merged
hank820 pushed a commit to hank820/connectedhomeip that referenced this pull request Oct 27, 2021
@hanksuu
Fix crash in identify-server.cpp
af41d56 
Reference from aea917b

Add identify support ot linux/all-cluster-app and fix initialization (project-chip#10907)
@pankore pankore mentioned this pull request Oct 27, 2021
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 27, 2021
@bzbarsky-apple
Fix boot crash in all-clusters-app on esp32
a6d9932 
project-chip#10907 added some
identify bits on Linux only but changed the core cluster impl to
assume that those bits are always there.

This change stops assuming that identify is actually configured on
every endpoint that supports it, since nothing enforces that.
@bzbarsky-apple bzbarsky-apple mentioned this pull request Oct 27, 2021
Merged
woody-apple pushed a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 27, 2021
@bzbarsky-apple
Fix boot crash in all-clusters-app on esp32
239e345 
project-chip#10907 added some
identify bits on Linux only but changed the core cluster impl to
assume that those bits are always there.

This change stops assuming that identify is actually configured on
every endpoint that supports it, since nothing enforces that.
andy31415 pushed a commit that referenced this pull request Oct 27, 2021
@bzbarsky-apple
Fix boot crash in all-clusters-app on esp32 (#11079)
cb5818f 
#10907 added some
identify bits on Linux only but changed the core cluster impl to
assume that those bits are always there.

This change stops assuming that identify is actually configured on
every endpoint that supports it, since nothing enforces that.
hank820 pushed a commit to hank820/connectedhomeip that referenced this pull request Oct 28, 2021
@hanksuu
Fix crash in identify-server.cpp
569de7a 
Reference from aea917b

Add identify support ot linux/all-cluster-app and fix initialization (project-chip#10907)
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@JasonLiuZhuoCheng
Add identify support ot linux/all-cluster-app and fix initialization (p…
a1716bd 
…roject-chip#10907)

* add identify support to linux/all-cluster-app

* fix identify init
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
@bzbarsky-apple @JasonLiuZhuoCheng
Fix boot crash in all-clusters-app on esp32 (project-chip#11079)
eb2b7ee 
project-chip#10907 added some
identify bits on Linux only but changed the core cluster impl to
assume that those bits are always there.

This change stops assuming that identify is actually configured on
every endpoint that supports it, since nothing enforces that.
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
@bzbarsky-apple @carol-apple
Fix boot crash in all-clusters-app on esp32 (project-chip#11079)
9dc47a3 
project-chip#10907 added some
identify bits on Linux only but changed the core cluster impl to
assume that those bits are always there.

This change stops assuming that identify is actually configured on
every endpoint that supports it, since nothing enforces that.
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
@bzbarsky-apple
Fix boot crash in all-clusters-app on esp32 (project-chip#11079)
7321e90 
project-chip#10907 added some
identify bits on Linux only but changed the core cluster impl to
assume that those bits are always there.

This change stops assuming that identify is actually configured on
every endpoint that supports it, since nothing enforces that.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anush-apple anush-apple Awaiting requested review from anush-apple

@balducci-apple balducci-apple Awaiting requested review from balducci-apple

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

@carol-apple carol-apple Awaiting requested review from carol-apple

@chrisdecenzo chrisdecenzo Awaiting requested review from chrisdecenzo

@chulspro chulspro Awaiting requested review from chulspro

@Damian-Nordic Damian-Nordic Awaiting requested review from Damian-Nordic

@emargolis emargolis Awaiting requested review from emargolis

@erjiaqing erjiaqing Awaiting requested review from erjiaqing

@franck-apple franck-apple Awaiting requested review from franck-apple

@hawk248 hawk248 Awaiting requested review from hawk248

@jelderton jelderton Awaiting requested review from jelderton

@jepenven-silabs jepenven-silabs Awaiting requested review from jepenven-silabs

@kghost kghost Awaiting requested review from kghost

@LuDuda LuDuda Awaiting requested review from LuDuda

@mlepage-google mlepage-google Awaiting requested review from mlepage-google

@msandstedt msandstedt Awaiting requested review from msandstedt

@mspang mspang Awaiting requested review from mspang

@pan-apple pan-apple Awaiting requested review from pan-apple

@robszewczyk robszewczyk Awaiting requested review from robszewczyk

@sagar-apple sagar-apple Awaiting requested review from sagar-apple

@saurabhst saurabhst Awaiting requested review from saurabhst

@tcarmelveilleux tcarmelveilleux Awaiting requested review from tcarmelveilleux

@tecimovic tecimovic Awaiting requested review from tecimovic

@turon turon Awaiting requested review from turon

@vivien-apple vivien-apple Awaiting requested review from vivien-apple

@wbschiller wbschiller Awaiting requested review from wbschiller

@yufengwangca yufengwangca Awaiting requested review from yufengwangca

@yunhanw-google yunhanw-google Awaiting requested review from yunhanw-google

Assignees
No one assigned
Labels
app examples review - approved
Projects
None yet
Milestone
Test Event 7
Development

Successfully merging this pull request may close these issues.

[TC-I-2.2] identify-time Attribute is not correctly decrementing over time
4 participants
@andy31415 @woody-apple @jmartinez-silabs @franck-apple