Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix identify cluster trigger effect #10958

Merged
merged 4 commits into from Oct 27, 2021
Merged

Bugfix identify cluster trigger effect #10958

merged 4 commits into from Oct 27, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 26, 2021

Problem

Change overview

  • add support for trigger effect command for the all-cluster-app

Testing

Test with all-cluster-app and chip-device-ctrl

@github-actions
Copy link

github-actions bot commented Oct 26, 2021

PR #10958: Size comparison from 62a6f85 to 41becde

8 builds (for k32w, p6, qpg, telink)
platform target config section 62a6f85 41becde change % change
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515140 515140 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78712 78712 0 0.0
.data 1900 1900 0 0.0
.text 613776 613520 -256 -0.0
p6 lock-app default .bss 67176 67176 0 0.0
.data 2416 2416 0 0.0
.heap 963752 963752 0 0.0
.text 1126088 1126088 0 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485044 484772 -272 -0.1
lock-app qpg6100+debug .bss 51360 51360 0 0.0
.data 956 956 0 0.0
.text 461264 461264 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69940 69940 0 0.0
noinit 33216 33216 0 0.0
text 457672 457368 -304 -0.1

Increases above 1.0% from 62a6f85 to 41becde:

platform target config section 62a6f85 41becde change % change
linux all-clusters-app debug .init_array 512 520 8 1.6
12 builds (for efr32, linux)
platform target config section 62a6f85 41becde change % change
efr32 lighting-app BRD4161A .bss 113684 113684 0 0.0
.data 1752 1752 0 0.0
.text 735816 735288 -528 -0.1
lock-app BRD4161A .bss 111540 111540 0 0.0
.data 1712 1712 0 0.0
.text 715080 715080 0 0.0
window-app BRD4161A .bss 111852 111852 0 0.0
.data 1716 1716 0 0.0
.text 715876 715876 0 0.0
lighting-app BRD4161A+rpc .bss 130188 130188 0 0.0
.data 1852 1852 0 0.0
.text 723232 722704 -528 -0.1
linux all-clusters-app debug .bss 50160 50224 64 0.1
.data 978 978 0 0.0
.data.rel.ro 60640 60544 -96 -0.2
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 520 8 1.6
.rodata 134517 134773 256 0.2
.text 1356946 1360066 3120 0.2
chip-tool debug .bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94896 94896 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208068 208068 0 0.0
.text 3642741 3642741 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1023714 1023714 0 0.0
ota-requestor-app debug .bss 208320 208320 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 129000 129000 0 0.0
.text 1145602 1145602 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599458 0 0.0
tv-app debug .bss 215536 215536 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 57424 57424 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152072 152072 0 0.0
.text 1454338 1454338 0 0.0
bridge-app debug+rpc .bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27112 27112 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109740 0 0.0
.text 1064293 1064293 0 0.0
lighting-app debug+rpc .bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53808 53824 16 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 127889 992 0.8
.text 1262178 1259122 -3056 -0.2
4 builds (for mbed)
platform target config section 62a6f85 41becde change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179596 -8 -0.0
.data 5192 5192 0 0.0
.heap 851648 851656 8 0.0
.text 1251552 1251720 168 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219256 1219000 -256 -0.0
lock-app CY8CPROTO_062_4343W+release .bss 169980 169980 0 0.0
.data 5432 5432 0 0.0
.heap 861032 861032 0 0.0
.text 1197280 1197280 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 62a6f85 41becde change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198072 198056 -16 -0.0
.flash.text 874742 875050 308 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60736 -8 -0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206832 206808 -24 -0.0
.flash.text 905807 906055 248 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97100 97100 0 0.0
text 577204 576944 -260 -0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93500 93500 0 0.0
text 558764 558764 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94700 94700 0 0.0
text 561868 561868 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111204 111204 0 0.0
rodata 93476 93476 0 0.0
text 558508 558508 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108376 108376 0 0.0
rodata 87876 87876 0 0.0
text 550396 550136 -260 -0.0
nrf5340dk_nrf5340_cpuapp bss 113508 113508 0 0.0
rodata 92340 92340 0 0.0
text 506676 506412 -264 -0.1
lock-app nrf5340dk_nrf5340_cpuapp bss 112580 112580 0 0.0
rodata 88760 88760 0 0.0
text 488228 488228 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@github-actions
Copy link

github-actions bot commented Oct 26, 2021

PR #10958: Size comparison from 4ab05ae to fb19dcb

8 builds (for k32w, p6, qpg, telink)
platform target config section 4ab05ae fb19dcb change % change
k32w lock-app k32w061+debug .bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 515240 515240 0 0.0
shell k32w061+debug .bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359572 359572 0 0.0
lighting-app k32w061+se05x+release .bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 613876 613876 0 0.0
p6 lock-app default .bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1126192 1126192 0 0.0
qpg lighting-app qpg6100+debug .bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485144 485144 0 0.0
lock-app qpg6100+debug .bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 461364 461364 0 0.0
persistent-storage-app qpg6100+debug .bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 457672 457672 0 0.0

Increases above 1.0% from 4ab05ae to fb19dcb:

platform target config section 4ab05ae fb19dcb change % change
linux all-clusters-app debug .init_array 512 520 8 1.6
12 builds (for efr32, linux)
platform target config section 4ab05ae fb19dcb change % change
efr32 lighting-app BRD4161A .bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 735912 735912 0 0.0
lock-app BRD4161A .bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 715176 715176 0 0.0
window-app BRD4161A .bss 111860 111860 0 0.0
.data 1716 1716 0 0.0
.text 716076 716076 0 0.0
lighting-app BRD4161A+rpc .bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 723336 723336 0 0.0
linux all-clusters-app debug .bss 50160 50224 64 0.1
.data 978 978 0 0.0
.data.rel.ro 60800 60704 -96 -0.2
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 512 520 8 1.6
.rodata 134517 134773 256 0.2
.text 1356946 1360066 3120 0.2
chip-tool debug .bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 94896 94896 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 416 416 0 0.0
.rodata 208068 208068 0 0.0
.text 3642741 3642741 0 0.0
ota-provider-app debug .bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110344 110344 0 0.0
.text 1023714 1023714 0 0.0
ota-requestor-app debug .bss 208320 208320 0 0.0
.data 752 752 0 0.0
.data.rel.ro 25928 25928 0 0.0
.dynamic 592 592 0 0.0
.got 4144 4144 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 129000 129000 0 0.0
.text 1145602 1145602 0 0.0
shell debug .bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76495 76495 0 0.0
.text 599458 599458 0 0.0
tv-app debug .bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152072 152072 0 0.0
.text 1454338 1454338 0 0.0
bridge-app debug+rpc .bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 109740 109740 0 0.0
.text 1064293 1064293 0 0.0
lighting-app debug+rpc .bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 126897 126897 0 0.0
.text 1262178 1262178 0 0.0
4 builds (for mbed)
platform target config section 4ab05ae fb19dcb change % change
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179604 179596 -8 -0.0
.data 5192 5192 0 0.0
.heap 851648 851656 8 0.0
.text 1251648 1251816 168 0.0
lighting-app CY8CPROTO_062_4343W+release .bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1219352 1219352 0 0.0
lock-app CY8CPROTO_062_4343W+release .bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1197384 1197384 0 0.0
pigweed-app CY8CPROTO_062_4343W+release .bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
12 builds (for esp32, nrfconnect)
platform target config section 4ab05ae fb19dcb change % change
esp32 all-clusters-app c3devkit .dram0.bss 58232 58232 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198176 198152 -24 -0.0
.flash.text 874742 875050 308 0.0
.iram0.text 57564 57564 0 0.0
m5stack .dram0.bss 60744 60736 -8 -0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 206928 206904 -24 -0.0
.flash.text 905807 906139 332 0.0
.iram0.text 125115 125115 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 bss 112136 112136 0 0.0
rodata 97200 97200 0 0.0
text 577204 577204 0 0.0
lock-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93600 93600 0 0.0
text 558764 558764 0 0.0
pigweed-app nrf52840dk_nrf52840 bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 bss 111308 111308 0 0.0
rodata 94800 94800 0 0.0
text 561868 561868 0 0.0
pump-controller-app nrf52840dk_nrf52840 bss 111208 111208 0 0.0
rodata 93576 93576 0 0.0
text 558508 558508 0 0.0
shell nrf52840dk_nrf52840 bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
lighting-app nrf52840dk_nrf52840+rpc bss 108380 108380 0 0.0
rodata 87976 87976 0 0.0
text 550396 550396 0 0.0
nrf5340dk_nrf5340_cpuapp bss 113512 113512 0 0.0
rodata 92440 92440 0 0.0
text 506676 506676 0 0.0
lock-app nrf5340dk_nrf5340_cpuapp bss 112584 112584 0 0.0
rodata 88860 88860 0 0.0
text 488228 488228 0 0.0
shell nrf5340dk_nrf5340_cpuapp bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0

@franck-apple franck-apple added this to the Test Event 7 milestone Oct 26, 2021
@github-actions
Copy link

github-actions bot commented Oct 27, 2021

PR #10958: Size comparison from 22f8115 to f236af5

Increases (4 builds for esp32, linux, mbed)
platform target config section 22f8115 f236af5 change % change
esp32 all-clusters-app c3devkit (read only) 875790 876086 296 0.0
.flash.text 875790 876086 296 0.0
m5stack (read only) 906891 907123 232 0.0
.flash.text 906891 907123 232 0.0
linux all-clusters-app debug (read only) 1634209 1636273 2064 0.1
.rodata 135541 135765 224 0.2
.text 1366930 1368818 1888 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288664 2288896 232 0.0
.heap 851640 851648 8 0.0
.text 1251264 1251496 232 0.0
Decreases (4 builds for esp32, linux, mbed)
platform target config section 22f8115 f236af5 change % change
esp32 all-clusters-app c3devkit (read/write) 1306456 1306432 -24 -0.0
.dram0.bss 58240 58232 -8 -0.0
.flash.rodata 198520 198496 -24 -0.0
m5stack (read/write) 426264 426224 -40 -0.0
.dram0.bss 60752 60736 -16 -0.0
.flash.rodata 207264 207240 -24 -0.0
linux all-clusters-app debug (read/write) 117408 117184 -224 -0.2
.bss 50320 50224 -96 -0.2
.data.rel.ro 60864 60736 -128 -0.2
mbed all-clusters-app CY8CPROTO_062_4343W+release .bss 179612 179604 -8 -0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section 22f8115 f236af5 change % change
efr32 lighting-app BRD4161A (read only) 737104 737104 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737096 737096 0 0.0
BRD4161A+rpc (read only) 724536 724536 0 0.0
(read/write) 132052 132052 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724528 724528 0 0.0
lock-app BRD4161A (read only) 716368 716368 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716360 716360 0 0.0
window-app BRD4161A (read only) 717276 717276 0 0.0
(read/write) 113584 113584 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717268 717268 0 0.0
esp32 all-clusters-app c3devkit (read only) 875790 876086 296 0.0
(read/write) 1306456 1306432 -24 -0.0
.dram0.bss 58240 58232 -8 -0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198520 198496 -24 -0.0
.flash.text 875790 876086 296 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 906891 907123 232 0.0
(read/write) 426264 426224 -40 -0.0
.dram0.bss 60752 60736 -16 -0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207264 207240 -24 -0.0
.flash.text 906891 907123 232 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701096 701096 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614676 614676 0 0.0
lock-app k32w061+debug (read/write) 592900 592900 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516040 516040 0 0.0
shell k32w061+debug (read/write) 425236 425236 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359604 359604 0 0.0
linux all-clusters-app debug (read only) 1634209 1636273 2064 0.1
(read/write) 117408 117184 -224 -0.2
.bss 50320 50224 -96 -0.2
.data 978 978 0 0.0
.data.rel.ro 60864 60736 -128 -0.2
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135765 224 0.2
.text 1366930 1368818 1888 0.1
bridge-app debug+rpc (read only) 1275693 1275693 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110684 0 0.0
.text 1069669 1069669 0 0.0
chip-tool debug (read only) 4149509 4149509 0 0.0
(read/write) 120224 120224 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 95552 95552 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 210704 210704 0 0.0
.text 3680421 3680421 0 0.0
lighting-app debug+rpc (read only) 1527209 1527209 0 0.0
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127889 0 0.0
.text 1267298 1267298 0 0.0
ota-provider-app debug (read only) 1234753 1234753 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1027810 1027810 0 0.0
ota-requestor-app debug (read only) 1292033 1292033 0 0.0
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127904 0 0.0
.text 1066530 1066530 0 0.0
shell debug (read only) 778361 778361 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76527 0 0.0
.text 600706 600706 0 0.0
tv-app debug (read only) 1753753 1753753 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152984 0 0.0
.text 1459058 1459058 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288664 2288896 232 0.0
.bss 179612 179604 -8 -0.0
.data 5192 5192 0 0.0
.heap 851640 851648 8 0.0
.text 1251264 1251496 232 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2255896 2255896 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218496 1218496 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2233928 2233928 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196528 1196528 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862967 862967 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577704 577704 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823807 823807 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550896 550896 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788006 788006 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507176 507176 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839911 839911 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559264 559264 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764954 764954 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488728 488728 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844311 844311 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562368 562368 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839631 839631 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559008 559008 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776579 776579 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520368 520368 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691634 691634 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440980 440980 0 0.0
p6 lock-app default (read/write) 2169104 2169104 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127368 1127368 0 0.0
qpg lighting-app qpg6100+debug (read only) 491272 491272 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 485952 485952 0 0.0
lock-app qpg6100+debug (read only) 467492 467492 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462172 462172 0 0.0
persistent-storage-app qpg6100+debug (read only) 155220 155220 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149900 149900 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664678 664678 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458278 458278 0 0.0

@github-actions
Copy link

Size increase report for "esp32-example-build" from 22f8115

File Section File VM
chip-all-clusters-app.elf .flash.text 296 296
chip-all-clusters-app.elf .dram0.heap_start 0 8
chip-all-clusters-app.elf .dram0.bss 0 -8
chip-all-clusters-app.elf .flash.rodata -24 -24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,430
.flash.text,296,296
.strtab,0,265
.debug_str,0,216
.debug_loc,0,96
.symtab,0,32
.debug_abbrev,0,18
.debug_ranges,0,16
.dram0.heap_start,8,0
.shstrtab,0,3
.riscv.attributes,0,-1
.dram0.bss,-8,0
.flash.rodata,-24,-24
.debug_line,0,-31
[Unmapped],0,-272


@github-actions
Copy link

github-actions bot commented Oct 27, 2021

PR #10958: Size comparison from c80412e to 3154cf6

Increases (4 builds for esp32, linux, mbed)
platform target config section c80412e 3154cf6 change % change
esp32 all-clusters-app c3devkit (read only) 876062 876374 312 0.0
(read/write) 1306520 1306568 48 0.0
.flash.rodata 198568 198616 48 0.0
.flash.text 876062 876374 312 0.0
m5stack (read only) 907147 907387 240 0.0
(read/write) 426312 426360 48 0.0
.flash.rodata 207312 207360 48 0.0
.flash.text 907147 907387 240 0.0
linux all-clusters-app debug (read only) 1636385 1638353 1968 0.1
.rodata 135541 135765 224 0.2
.text 1369106 1370850 1744 0.1
mbed all-clusters-app CY8CPROTO_062_4343W+release (read/write) 2288904 2289200 296 0.0
.text 1251504 1251800 296 0.0
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
platform target config section c80412e 3154cf6 change % change
efr32 lighting-app BRD4161A (read only) 737280 737280 0 0.0
(read/write) 115444 115444 0 0.0
.bss 113692 113692 0 0.0
.data 1752 1752 0 0.0
.text 737272 737272 0 0.0
BRD4161A+rpc (read only) 724712 724712 0 0.0
(read/write) 132052 132052 0 0.0
.bss 130196 130196 0 0.0
.data 1852 1852 0 0.0
.text 724704 724704 0 0.0
lock-app BRD4161A (read only) 716544 716544 0 0.0
(read/write) 113260 113260 0 0.0
.bss 111548 111548 0 0.0
.data 1712 1712 0 0.0
.text 716536 716536 0 0.0
window-app BRD4161A (read only) 717468 717468 0 0.0
(read/write) 113584 113584 0 0.0
.bss 111868 111868 0 0.0
.data 1716 1716 0 0.0
.text 717460 717460 0 0.0
esp32 all-clusters-app c3devkit (read only) 876062 876374 312 0.0
(read/write) 1306520 1306568 48 0.0
.dram0.bss 58248 58248 0 0.0
.dram0.data 16464 16464 0 0.0
.flash.rodata 198568 198616 48 0.0
.flash.text 876062 876374 312 0.0
.iram0.text 57564 57564 0 0.0
m5stack (read only) 907147 907387 240 0.0
(read/write) 426312 426360 48 0.0
.dram0.bss 60752 60752 0 0.0
.dram0.data 32084 32084 0 0.0
.flash.rodata 207312 207360 48 0.0
.flash.text 907147 907387 240 0.0
.iram0.text 125115 125115 0 0.0
k32w lighting-app k32w061+se05x+release (read/write) 701256 701256 0 0.0
.bss 78720 78720 0 0.0
.data 1900 1900 0 0.0
.text 614836 614836 0 0.0
lock-app k32w061+debug (read/write) 593060 593060 0 0.0
.bss 69196 69196 0 0.0
.data 1864 1864 0 0.0
.text 516200 516200 0 0.0
shell k32w061+debug (read/write) 425348 425348 0 0.0
.bss 63256 63256 0 0.0
.data 672 672 0 0.0
.text 359716 359716 0 0.0
linux all-clusters-app debug (read only) 1636385 1638353 1968 0.1
(read/write) 117472 117472 0 0.0
.bss 50320 50320 0 0.0
.data 978 978 0 0.0
.data.rel.ro 60928 60928 0 0.0
.dynamic 592 592 0 0.0
.got 4088 4088 0 0.0
.init 27 27 0 0.0
.init_array 520 520 0 0.0
.rodata 135541 135765 224 0.2
.text 1369106 1370850 1744 0.1
bridge-app debug+rpc (read only) 1277645 1277645 0 0.0
(read/write) 85096 85096 0 0.0
.bss 51856 51856 0 0.0
.data 976 976 0 0.0
.data.rel.ro 27272 27272 0 0.0
.dynamic 592 592 0 0.0
.got 3952 3952 0 0.0
.init 27 27 0 0.0
.init_array 400 400 0 0.0
.rodata 110684 110684 0 0.0
.text 1071621 1071621 0 0.0
chip-tool debug (read only) 4174429 4174429 0 0.0
(read/write) 120896 120896 0 0.0
.bss 17680 17680 0 0.0
.data 1584 1584 0 0.0
.data.rel.ro 96208 96208 0 0.0
.dynamic 592 592 0 0.0
.got 4368 4368 0 0.0
.init 27 27 0 0.0
.init_array 424 424 0 0.0
.rodata 212496 212496 0 0.0
.text 3702037 3702037 0 0.0
lighting-app debug+rpc (read only) 1529385 1529385 0 0.0
(read/write) 101520 101520 0 0.0
.bss 41176 41176 0 0.0
.data 1106 1106 0 0.0
.data.rel.ro 53968 53968 0 0.0
.dynamic 608 608 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 528 528 0 0.0
.rodata 127889 127889 0 0.0
.text 1269474 1269474 0 0.0
ota-provider-app debug (read only) 1236913 1236913 0 0.0
(read/write) 67776 67776 0 0.0
.bss 37440 37440 0 0.0
.data 752 752 0 0.0
.data.rel.ro 24488 24488 0 0.0
.dynamic 592 592 0 0.0
.got 4016 4016 0 0.0
.init 27 27 0 0.0
.init_array 440 440 0 0.0
.rodata 110984 110984 0 0.0
.text 1029970 1029970 0 0.0
ota-requestor-app debug (read only) 1294321 1294321 0 0.0
(read/write) 76264 76264 0 0.0
.bss 44960 44960 0 0.0
.data 816 816 0 0.0
.data.rel.ro 25352 25352 0 0.0
.dynamic 592 592 0 0.0
.got 3984 3984 0 0.0
.init 27 27 0 0.0
.init_array 512 512 0 0.0
.rodata 127904 127904 0 0.0
.text 1068818 1068818 0 0.0
shell debug (read only) 780809 780809 0 0.0
(read/write) 57376 57376 0 0.0
.bss 16136 16136 0 0.0
.data 242 242 0 0.0
.data.rel.ro 36496 36496 0 0.0
.dynamic 592 592 0 0.0
.got 3528 3528 0 0.0
.init 27 27 0 0.0
.init_array 336 336 0 0.0
.rodata 76527 76527 0 0.0
.text 603154 603154 0 0.0
tv-app debug (read only) 1756201 1756201 0 0.0
(read/write) 281432 281432 0 0.0
.bss 215568 215568 0 0.0
.data 2032 2032 0 0.0
.data.rel.ro 58192 58192 0 0.0
.dynamic 592 592 0 0.0
.got 4408 4408 0 0.0
.init 27 27 0 0.0
.init_array 608 608 0 0.0
.rodata 152984 152984 0 0.0
.text 1461506 1461506 0 0.0
mbed all-clusters-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2288904 2289200 296 0.0
.bss 179612 179612 0 0.0
.data 5192 5192 0 0.0
.heap 851640 851640 0 0.0
.text 1251504 1251800 296 0.0
lighting-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2256088 2256088 0 0.0
.bss 171060 171060 0 0.0
.data 5464 5464 0 0.0
.heap 859920 859920 0 0.0
.text 1218688 1218688 0 0.0
lock-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 2234120 2234120 0 0.0
.bss 169988 169988 0 0.0
.data 5432 5432 0 0.0
.heap 861024 861024 0 0.0
.text 1196720 1196720 0 0.0
pigweed-app CY8CPROTO_062_4343W+release (read only) 6224 6224 0 0.0
(read/write) 1139680 1139680 0 0.0
.bss 11760 11760 0 0.0
.data 4360 4360 0 0.0
.heap 1020328 1020328 0 0.0
.text 103064 103064 0 0.0
nrfconnect lighting-app nrf52840dk_nrf52840 (read/write) 862983 862983 0 0.0
bss 112136 112136 0 0.0
rodata 97504 97504 0 0.0
text 577724 577724 0 0.0
nrf52840dk_nrf52840+rpc (read/write) 823823 823823 0 0.0
bss 108380 108380 0 0.0
rodata 88280 88280 0 0.0
text 550916 550916 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 788022 788022 0 0.0
bss 113512 113512 0 0.0
rodata 92744 92744 0 0.0
text 507196 507196 0 0.0
lock-app nrf52840dk_nrf52840 (read/write) 839927 839927 0 0.0
bss 111208 111208 0 0.0
rodata 93904 93904 0 0.0
text 559284 559284 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 764970 764970 0 0.0
bss 112584 112584 0 0.0
rodata 89164 89164 0 0.0
text 488748 488748 0 0.0
pigweed-app nrf52840dk_nrf52840 (read/write) 497339 497339 0 0.0
bss 51824 51824 0 0.0
rodata 45776 45776 0 0.0
text 339456 339456 0 0.0
pump-app nrf52840dk_nrf52840 (read/write) 844327 844327 0 0.0
bss 111308 111308 0 0.0
rodata 95104 95104 0 0.0
text 562388 562388 0 0.0
pump-controller-app nrf52840dk_nrf52840 (read/write) 839647 839647 0 0.0
bss 111208 111208 0 0.0
rodata 93880 93880 0 0.0
text 559028 559028 0 0.0
shell nrf52840dk_nrf52840 (read/write) 776531 776531 0 0.0
bss 109072 109072 0 0.0
rodata 72536 72536 0 0.0
text 520324 520324 0 0.0
nrf5340dk_nrf5340_cpuapp (read/write) 691586 691586 0 0.0
bss 110056 110056 0 0.0
rodata 67180 67180 0 0.0
text 440936 440936 0 0.0
p6 lock-app default (read/write) 2169360 2169360 0 0.0
.bss 67184 67184 0 0.0
.data 2416 2416 0 0.0
.heap 963744 963744 0 0.0
.text 1127624 1127624 0 0.0
qpg lighting-app qpg6100+debug (read only) 491416 491416 0 0.0
(read/write) 114144 114144 0 0.0
.bss 52416 52416 0 0.0
.data 1000 1000 0 0.0
.text 486096 486096 0 0.0
lock-app qpg6100+debug (read only) 467636 467636 0 0.0
(read/write) 114140 114140 0 0.0
.bss 51368 51368 0 0.0
.data 956 956 0 0.0
.text 462316 462316 0 0.0
persistent-storage-app qpg6100+debug (read only) 155244 155244 0 0.0
(read/write) 114140 114140 0 0.0
.bss 27752 27752 0 0.0
.data 372 372 0 0.0
.text 149924 149924 0 0.0
telink lighting-app tlsr9518adk80d (read/write) 664718 664718 0 0.0
bss 69944 69944 0 0.0
noinit 33216 33216 0 0.0
text 458320 458320 0 0.0

@woody-apple woody-apple merged commit 30fd6f9 into project-chip:master Oct 27, 2021
JasonLiuZhuoCheng pushed a commit to JasonLiuZhuoCheng/connectedhomeip that referenced this pull request Oct 28, 2021
* add dummy processing for trigger effect in all-cluster-app

* add trigger effect commands to all cluster app

* add dummy impl. for trigger effect

* regen all
carol-apple pushed a commit to carol-apple/connectedhomeip that referenced this pull request Oct 28, 2021
* add dummy processing for trigger effect in all-cluster-app

* add trigger effect commands to all cluster app

* add dummy impl. for trigger effect

* regen all
PSONALl pushed a commit to PSONALl/connectedhomeip that referenced this pull request Dec 3, 2021
* add dummy processing for trigger effect in all-cluster-app

* add trigger effect commands to all cluster app

* add dummy impl. for trigger effect

* regen all
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TC-I-2.3] Issue cluster's trigger-effect command results in Failure for all values in test case steps
6 participants