-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix identify cluster trigger effect #10958
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
changed the title
Bugfix/10863 trigger effect
Bugfix identify cluster trigger effect
Oct 26, 2021
pullapprove
bot
requested review from
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chulspro,
Damian-Nordic,
emargolis,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kpschoedel,
LuDuda,
mlepage-google,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst,
selissia and
tecimovic
October 26, 2021 10:20
pullapprove
bot
requested review from
woody-apple,
yufengwangca and
yunhanw-google
October 26, 2021 10:20
PR #10958: Size comparison from 62a6f85 to 41becde 8 builds (for k32w, p6, qpg, telink)
Increases above 1.0% from 62a6f85 to 41becde:
12 builds (for efr32, linux)
4 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
jmartinez-silabs
approved these changes
Oct 26, 2021
PR #10958: Size comparison from 4ab05ae to fb19dcb 8 builds (for k32w, p6, qpg, telink)
Increases above 1.0% from 4ab05ae to fb19dcb:
12 builds (for efr32, linux)
4 builds (for mbed)
12 builds (for esp32, nrfconnect)
|
msandstedt
approved these changes
Oct 26, 2021
woody-apple
approved these changes
Oct 27, 2021
examples/all-clusters-app/all-clusters-common/all-clusters-app.zap
Outdated
Show resolved
Hide resolved
PR #10958: Size comparison from 22f8115 to f236af5 Increases (4 builds for esp32, linux, mbed)
Decreases (4 builds for esp32, linux, mbed)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
andy31415
approved these changes
Oct 27, 2021
Size increase report for "esp32-example-build" from 22f8115
Full report output
|
PR #10958: Size comparison from c80412e to 3154cf6 Increases (4 builds for esp32, linux, mbed)
Full report (36 builds for efr32, esp32, k32w, linux, mbed, nrfconnect, p6, qpg, telink)
|
JasonLiuZhuoCheng
pushed a commit
to JasonLiuZhuoCheng/connectedhomeip
that referenced
this pull request
Oct 28, 2021
* add dummy processing for trigger effect in all-cluster-app * add trigger effect commands to all cluster app * add dummy impl. for trigger effect * regen all
carol-apple
pushed a commit
to carol-apple/connectedhomeip
that referenced
this pull request
Oct 28, 2021
* add dummy processing for trigger effect in all-cluster-app * add trigger effect commands to all cluster app * add dummy impl. for trigger effect * regen all
PSONALl
pushed a commit
to PSONALl/connectedhomeip
that referenced
this pull request
Dec 3, 2021
* add dummy processing for trigger effect in all-cluster-app * add trigger effect commands to all cluster app * add dummy impl. for trigger effect * regen all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
trigger-effect
command results in Failure for all values in test case steps #10863Change overview
Testing
Test with all-cluster-app and chip-device-ctrl