-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ConcreteAttributePath for reads below ReadSingleClusterData. #10397
Use ConcreteAttributePath for reads below ReadSingleClusterData. #10397
Conversation
The ReadSingleClusterData in TestReportingEngine.cpp was not being used, because it had the wrong signature. And making it be used by fixing the signature apparently makes the test fail...
Document.connectedhomeip/src/app/InteractionModelEngine.h Lines 246 to 250 in 827aedd
This comment was generated by todo based on a
|
Size increase report for "gn_qpg-example-build" from 02cbf69
Full report output
|
Size increase report for "nrfconnect-example-build" from 02cbf69
Full report output
|
Size increase report for "esp32-example-build" from 02cbf69
Full report output
|
@saurabhst @msandstedt @Damian-Nordic @jelderton @LuDuda @jepenven-silabs @jmartinez-silabs Please take a look? |
project-chip#10397 modified APIs that were being used in new places at the same time in project-chip#10459, project-chip#10362, project-chip#10464, and project-chip#10374, so now the tree does not compile.
The ReadSingleClusterData in TestReportingEngine.cpp was not being
used, because it had the wrong signature. And making it be used
by fixing the signature apparently makes the test fail...
Problem
We're using ClusterInfo, which is a very generic data structure that may not be a valid concrete attribute path.
Change overview
Use ConcreteAttributePath, which is what we will have after group/wildcard expansion.
Testing
Passes existing unit tests. No intended behavior changes.