Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ConcreteAttributePath for reads below ReadSingleClusterData. #10397

Merged

Conversation

bzbarsky-apple
Copy link
Contributor

The ReadSingleClusterData in TestReportingEngine.cpp was not being
used, because it had the wrong signature. And making it be used
by fixing the signature apparently makes the test fail...

Problem

We're using ClusterInfo, which is a very generic data structure that may not be a valid concrete attribute path.

Change overview

Use ConcreteAttributePath, which is what we will have after group/wildcard expansion.

Testing

Passes existing unit tests. No intended behavior changes.

The ReadSingleClusterData in TestReportingEngine.cpp was not being
used, because it had the wrong signature.  And making it be used
by fixing the signature apparently makes the test fail...
@todo
Copy link

todo bot commented Oct 11, 2021

Document.

* TODO: Document.
*/
CHIP_ERROR WriteSingleClusterData(ClusterInfo & aClusterInfo, TLV::TLVReader & aReader, WriteHandler * apWriteHandler);
} // namespace app
} // namespace chip


This comment was generated by todo based on a TODO comment in 827aedd in #10397. cc @bzbarsky-apple.

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 02cbf69

File Section File VM
chip-qpg6100-lighting-example.out .text 16 16
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.strtab,0,66
.debug_ranges,0,24
.debug_str,0,24
.debug_loc,0,18
.text,16,16
.shstrtab,0,2
[Unmapped],0,-16
.debug_abbrev,0,-44
.debug_line,0,-473
.debug_info,0,-6005

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 02cbf69

File Section File VM
chip-lock.elf text 12 12
chip-lock.elf device_handles 4 4
chip-lock.elf rodata -32 -28
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_loc,0,133
.debug_str,0,-5
.debug_line,0,-408
.debug_info,0,-920

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_loc,0,190
.strtab,0,66
.debug_ranges,0,24
.debug_str,0,22
text,12,12
device_handles,4,4
.shstrtab,0,-2
rodata,-28,-32
.debug_abbrev,0,-44
.debug_line,0,-486
.debug_info,0,-6074


@github-actions
Copy link

Size increase report for "esp32-example-build" from 02cbf69

File Section File VM
chip-all-clusters-app.elf .flash.text 12 12
chip-all-clusters-app.elf .flash.rodata -32 -32
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_loc,0,192
.strtab,0,66
.debug_str,0,22
[Unmapped],0,20
.flash.text,12,12
.shstrtab,0,-2
.flash.rodata,-32,-32
.debug_abbrev,0,-418
.debug_line,0,-442
.debug_info,0,-5982


@woody-apple
Copy link
Contributor

@bzbarsky-apple
Copy link
Contributor Author

@bzbarsky-apple bzbarsky-apple merged commit 7fd90f6 into project-chip:master Oct 15, 2021
@todo todo bot mentioned this pull request Oct 15, 2021
@bzbarsky-apple bzbarsky-apple deleted the use-concrete-attribute-path branch October 15, 2021 15:59
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this pull request Oct 15, 2021
project-chip#10397 modified
APIs that were being used in new places at the same time in
project-chip#10459,
project-chip#10362,
project-chip#10464, and
project-chip#10374, so now the
tree does not compile.
andy31415 pushed a commit that referenced this pull request Oct 15, 2021
#10397 modified
APIs that were being used in new places at the same time in
#10459,
#10362,
#10464, and
#10374, so now the
tree does not compile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants