-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Descriptor]: Support read attribute with complex type via AttributeAccessInterface for descriptor cluster #10374
[Descriptor]: Support read attribute with complex type via AttributeAccessInterface for descriptor cluster #10374
Conversation
examples/pump-controller-app/pump-controller-common/pump-controller-app.zap
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, one other issue: with this change, reporting is broken. The old setup has the emberAfPluginDescriptorServerInitCallback
call in emberAfEndpointEnableDisable
which updates the stored values for the new topology. But in the new setup, that's not going to do anything once we stop writing to the attr store from the init callback. Instead, we need something to prod the reporting machinery when the set of enabled endpoints changes.
It's probably ok to have a followup for this so we can unblock the non-reporting use cases....
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, but the submodule changes should not be in this PR.
…ccessInterface for descriptor cluster
Size increase report for "gn_qpg-example-build" from add5a11
Full report output
|
Size increase report for "nrfconnect-example-build" from add5a11
Full report output
|
Size increase report for "esp32-example-build" from add5a11
Full report output
|
project-chip#10397 modified APIs that were being used in new places at the same time in project-chip#10459, project-chip#10362, project-chip#10464, and project-chip#10374, so now the tree does not compile.
Problem
What is being fixed? Examples:
Change overview
Support read attribute with complex type via AttributeAccessInterface for descriptor cluster.
Testing
How was this tested? (at least one bullet point required)