Generate github comments from size reports (small scale) #10124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem The current bloat report requires preserving large binaries, and has trouble matching tree parents for comparison. In a24a6c3 (PR project-chip#9331), many workflows started uploading small json artifacts contains size information for their builds, but these have not yet been used to generate reports. #### Change overview This change adds a run of `scripts/tools/memory/gh_report.py` to the periodic bloat check workflow, with tight rate limiting in case there are unexpected problems. #### Testing Manually run offline with various data sets, and minimally on the live repository.
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
Damian-Nordic,
franck-apple,
hawk248,
holbrookt,
jelderton,
jepenven-silabs,
jmartinez-silabs,
kghost,
LuDuda,
mlepage-google,
mrjerryjohns,
msandstedt,
mspang,
pan-apple,
robszewczyk,
sagar-apple,
saurabhst and
shana-apple
pullapprove
bot
requested review from
turon,
vivien-apple,
woody-apple and
yufengwangca
tcarmelveilleux
approved these changes
Sep 30, 2021
woody-apple
approved these changes
Sep 30, 2021
jmartinez-silabs
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The current bloat report requires preserving large binaries, and has
trouble matching tree parents for comparison.
In a24a6c3 (PR #9331), many workflows started uploading small json
artifacts contains size information for their builds, but these have not
yet been used to generate reports.
Change overview
This change adds a run of
scripts/tools/memory/gh_report.pyto theperiodic bloat check workflow, with tight rate limiting in case there
are unexpected problems.
Testing
Manually run offline with various data sets, and minimally on the live
repository.