-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change how we namespace our attribute ids #10110
Merged
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:attribute-ids
Sep 30, 2021
Merged
Change how we namespace our attribute ids #10110
bzbarsky-apple
merged 4 commits into
project-chip:master
from
bzbarsky-apple:attribute-ids
Sep 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
andy31415,
anush-apple,
austinh0,
balducci-apple,
carol-apple,
cecille,
chrisdecenzo,
Damian-Nordic,
emargolis,
erjiaqing,
franck-apple,
harimau-qirex,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
LuDuda,
msandstedt,
mspang,
pan-apple,
sagar-apple,
saurabhst,
shana-apple and
turon
September 30, 2021 14:31
tcarmelveilleux
approved these changes
Sep 30, 2021
bzbarsky-apple
force-pushed
the
attribute-ids
branch
from
September 30, 2021 15:47
3f257b9
to
046881d
Compare
msandstedt
approved these changes
Sep 30, 2021
bzbarsky-apple
force-pushed
the
attribute-ids
branch
2 times, most recently
from
September 30, 2021 18:44
bcdc52e
to
9b7675b
Compare
PR #10110: Size comparison from 9b7675b to c23becb 8 builds
|
woody-apple
approved these changes
Sep 30, 2021
This commit was created by installing the git-extras package and running: git sed -f g "Attributes::Ids::\([A-Za-z0-9]*\)" "Attributes::\1::Id"
This commit was created by installing the git-extras package and running: git sed " Ids::\([A-Za-z0-9]*\)" " \1::Id" -- src/app/clusters
bzbarsky-apple
force-pushed
the
attribute-ids
branch
from
September 30, 2021 19:22
9b7675b
to
1e2629c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Right now our namespacing looks like
ClusterName::Ids::AttributeName
. We want to have metadata about attributes other than the id, so are planning to introduce aClusterName::AttributeName
namespace anyway. And in that case we should have the ids beClusterName::AttributeName::Id
.Change overview
Do the above renaming.
Testing
No functionality changes. Tree compiles.