Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we namespace our attribute ids #10110

Merged
merged 4 commits into from
Sep 30, 2021

Conversation

bzbarsky-apple
Copy link
Contributor

Problem

Right now our namespacing looks like ClusterName::Ids::AttributeName. We want to have metadata about attributes other than the id, so are planning to introduce a ClusterName::AttributeName namespace anyway. And in that case we should have the ids be ClusterName::AttributeName::Id.

Change overview

Do the above renaming.

Testing

No functionality changes. Tree compiles.

@bzbarsky-apple bzbarsky-apple force-pushed the attribute-ids branch 2 times, most recently from bcdc52e to 9b7675b Compare September 30, 2021 18:44
@kpschoedel
Copy link
Contributor

PR #10110: Size comparison from 9b7675b to c23becb

8 builds
platform target config section c23becb 9b7675b change % change
k32w lock-app k32w061+debug .bss 68660 68660 0 0.0
.data 1860 1860 0 0.0
.text 514548 514548 0 0.0
shell k32w061+debug .bss 56688 56688 0 0.0
.data 672 672 0 0.0
.text 370068 370068 0 0.0
lighting-app k32w061+se05x+release .bss 78600 78600 0 0.0
.data 1896 1896 0 0.0
.text 613744 613744 0 0.0
p6 lock-app default .bss 67912 67912 0 0.0
.data 2416 2416 0 0.0
.heap 963016 963016 0 0.0
.text 1125016 1125016 0 0.0
qpg lighting-app qpg6100+debug .bss 53600 53600 0 0.0
.data 1000 1000 0 0.0
.text 486032 486032 0 0.0
lock-app qpg6100+debug .bss 52120 52120 0 0.0
.data 956 956 0 0.0
.text 461232 461232 0 0.0
persistent-storage-app qpg6100+debug .bss 17802 17802 0 0.0
.data 284 284 0 0.0
.text 102664 102664 0 0.0
telink lighting-app tlsr9518adk80d bss 71140 71140 0 0.0
noinit 33216 33216 0 0.0
text 459028 459028 0 0.0

@kpschoedel
Copy link
Contributor

PR #10110: Size comparison from 9b7675b to c23becb

Just testing new bloat reports with my own GH token.

This commit was created by installing the git-extras package and running:

  git sed -f g "Attributes::Ids::\([A-Za-z0-9]*\)" "Attributes::\1::Id"
This commit was created by installing the git-extras package and running:

  git sed " Ids::\([A-Za-z0-9]*\)" " \1::Id" -- src/app/clusters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants