Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Wifi Diagnostics attributes from platform #10096

Merged
merged 3 commits into from
Sep 30, 2021
Merged

Read Wifi Diagnostics attributes from platform #10096

merged 3 commits into from
Sep 30, 2021

Conversation

yufengwangca
Copy link
Contributor

Problem

What is being fixed? Examples:

  • Currently, the Wifi Diagnostic attributes are fully managed by the attribute store, we can only specify the default values in its xml definitions. We need to populate those attributes with the actual value from platform in run-time.

Change overview

Read Wifi Diagnostics attributes from platform

Testing

How was this tested? (at least one bullet point required)

  • chip-device-ctrl > zclread WiFiNetworkDiagnostics ChannelNumber 12344321 0 0
[1632974148.116498][987083:987091] CHIP:EM: Received message of type 0x5 with protocolId (0, 1) and MessageCounter:2 on exchange 46920i
[1632974148.116689][987083:987091] CHIP:ZCL: ReadAttributesResponse:
[1632974148.116696][987083:987091] CHIP:ZCL:   ClusterId: 0x0000_0036
[1632974148.116718][987083:987091] CHIP:ZCL:   attributeId: 0x0000_0003
[1632974148.116721][987083:987091] CHIP:ZCL:   status: Success                (0x0000)
[1632974148.116726][987083:987091] CHIP:ZCL:   attribute TLV Type: 0x04
[1632974148.116734][987083:987091] CHIP:ZCL:   attributeValue: 149
[1632974148.116832][987083:987091] CHIP:IN: Prepared encrypted message 0x1e52e58 to 0x0000000000BC5C01 of type 0x1 and protocolId (0, 1) on exchange 46920i with MessageCounter:3.
[1632974148.116876][987083:987091] CHIP:IN: Sending encrypted msg 0x1e52e58 with MessageCounter:3 to 0x0000000000BC5C01 at monotonic time: 942771037 msec
AttributeReadResult(path=AttributePath(nodeId=12344321, endpointId=0, clusterId=54, attributeId=3), status=0, value=149)

@github-actions
Copy link

Size increase report for "gn_qpg-example-build" from 25cb340

File Section File VM
chip-qpg6100-lighting-example.out .text 268 268
chip-qpg6100-lighting-example.out .bss 0 64
chip-qpg6100-lighting-example.out .data 4 4
chip-qpg6100-lighting-example.out .heap 0 -64
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-qpg6100-lighting-example.out and ./pull_artifact/chip-qpg6100-lighting-example.out:

sections,vmsize,filesize
.debug_info,0,69048
.debug_loc,0,4996
.debug_str,0,3402
.debug_line,0,2739
.debug_abbrev,0,2447
.strtab,0,1280
.symtab,0,672
.debug_ranges,0,432
.debug_frame,0,396
.text,268,268
.debug_aranges,0,160
.bss,64,0
.data,4,4
[ELF Program Headers],0,-32
.heap,-64,0
[Unmapped],0,-236

Comparing ./master_artifact/chip-qpg6100-lighting-example.out.map and ./pull_artifact/chip-qpg6100-lighting-example.out.map:

BLOAT EXECUTION FAILED WITH CODE 1:
bloaty: unknown file type for file './pull_artifact/chip-qpg6100-lighting-example.out.map'


@github-actions
Copy link

Size increase report for "esp32-example-build" from 25cb340

File Section File VM
chip-all-clusters-app.elf .flash.text 256 256
chip-all-clusters-app.elf .dram0.bss 0 24
chip-all-clusters-app.elf .dram0.heap_start 0 8
chip-all-clusters-app.elf .flash.rodata -200 -200
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-all-clusters-app.elf and ./pull_artifact/chip-all-clusters-app.elf:

sections,vmsize,filesize
.debug_info,0,69597
.debug_loc,0,3765
.debug_str,0,3463
.debug_line,0,3451
.debug_abbrev,0,1542
.strtab,0,1180
.debug_frame,0,588
.debug_ranges,0,360
.debug_aranges,0,264
.flash.text,256,256
.symtab,0,256
.dram0.bss,24,0
.dram0.heap_start,8,0
.riscv.attributes,0,-2
[Unmapped],0,-56
.flash.rodata,-200,-200


@github-actions
Copy link

Size increase report for "nrfconnect-example-build" from 25cb340

File Section File VM
chip-lock.elf text 644 644
chip-lock.elf rodata 192 192
chip-lock.elf bss 0 56
chip-lock.elf init_array 4 4
chip-lock.elf device_handles -8 -8
chip-lock.elf [LOAD #3 [RW]] 0 -24
Full report output
BLOAT REPORT

Files found only in the build output:
    report.csv

Comparing ./master_artifact/chip-shell.elf and ./pull_artifact/chip-shell.elf:

sections,vmsize,filesize
.debug_info,0,6541
.debug_str,0,2753
.debug_line,0,-1
.debug_loc,0,-5

Comparing ./master_artifact/chip-lock.elf and ./pull_artifact/chip-lock.elf:

sections,vmsize,filesize
.debug_info,0,89196
.debug_line,0,6871
.debug_loc,0,5503
.debug_abbrev,0,4673
.debug_str,0,3669
.strtab,0,1815
.symtab,0,896
text,644,644
.debug_ranges,0,536
.debug_frame,0,408
rodata,192,192
.debug_aranges,0,184
bss,56,0
init_array,4,4
.shstrtab,0,1
device_handles,-8,-8
[LOAD #3 [RW]],-24,0


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants