Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectivityManager members accessed out of scope. ToT broken on disabled WPA #10576

Closed
samadDotDev opened this issue Oct 15, 2021 · 2 comments · Fixed by #10627
Closed

ConnectivityManager members accessed out of scope. ToT broken on disabled WPA #10576

samadDotDev opened this issue Oct 15, 2021 · 2 comments · Fixed by #10627
Assignees
@yufengwangca

Comments

@samadDotDev
Copy link
Contributor

In src/platform/Linux/ConnectivityManagerImpl.h, some of the members such as ConnectivityManager::WiFiStationMode mWiFiStationMode are scoped under CHIP_DEVICE_CONFIG_ENABLE_WPA flag.
However, they are used out of its scope in ConnectivityManagerImpl.cpp such as within ConnectivityManagerImpl::_Init().

Tracing back, PR #10096 seems to have scoped these declarations under the flag but missed scoping their usages.

Consequently, build breaks when CHIP_DEVICE_CONFIG_ENABLE_WPA is disabled (by chip_enable_wifi or other means).
@msandstedt
Copy link
Contributor

CC @yufengwangca

@yufengwangca yufengwangca self-assigned this Oct 18, 2021
@yufengwangca yufengwangca mentioned this issue Oct 18, 2021
Merged
@msandstedt
Copy link
Contributor

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yufengwangca yufengwangca

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix compile error if disable CHIP_DEVICE_CONFIG_ENABLE_WPA
3 participants
@msandstedt @samadDotDev @yufengwangca