Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify that the status type for a Status argument for a command actually works #26317

Closed
mkardous-silabs opened this issue May 1, 2023 · 0 comments · Fixed by #26329
Closed

Verify that the status type for a Status argument for a command actually works #26317

mkardous-silabs opened this issue May 1, 2023 · 0 comments · Fixed by #26329
Assignees
@bzbarsky-apple

Comments

@mkardous-silabs
Copy link
Contributor

Description

When defining a response command, the command will have a Status argument. It is not clear if the status type works in the xml definition.

See https://github.com/project-chip/connectedhomeip/pull/26302/files#r1180940716 as reference.
@mkardous-silabs mkardous-silabs mentioned this issue May 1, 2023
Merged
bzbarsky-apple added a commit to bzbarsky-apple/connectedhomeip that referenced this issue May 2, 2023
@bzbarsky-apple
Make the "status" type match the spec.
29f766b 
It's 8 bits in the spec, not 16 bits.

Fixes project-chip#26317
@bzbarsky-apple bzbarsky-apple mentioned this issue May 2, 2023
Merged
jmartinez-silabs pushed a commit that referenced this issue May 3, 2023
@bzbarsky-apple
Make the "status" type match the spec. (#26329)
b1f1011 
It's 8 bits in the spec, not 16 bits.

Fixes #26317
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bzbarsky-apple bzbarsky-apple

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make the "status" type match the spec. bzbarsky-apple/connectedhomeip
2 participants
@bzbarsky-apple @mkardous-silabs