-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ICD] Initial Client Monitoring Cluster xml update #26302
Merged
bzbarsky-apple
merged 16 commits into
project-chip:master
from
mkardous-silabs:feature/update_cm
May 3, 2023
Merged
[ICD] Initial Client Monitoring Cluster xml update #26302
bzbarsky-apple
merged 16 commits into
project-chip:master
from
mkardous-silabs:feature/update_cm
May 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
amitnj,
andy31415,
anush-apple,
arkq,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
cliffamzn,
CodeChronos928,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
franck-apple,
gjc13,
harimau-qirex,
harsha-rajendran,
hawk248,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jmeg-sfy,
joonhaengHeo,
jtung-apple,
kkasperczyk-no,
ksperling-apple and
lazarkov
April 28, 2023 17:58
PR #26302: Size comparison from 3144434 to 560b023 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
mkardous-silabs
force-pushed
the
feature/update_cm
branch
from
May 2, 2023 14:22
560b023
to
e76f226
Compare
PR #26302: Size comparison from f587c34 to e76f226 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26302: Size comparison from f587c34 to 63fac64 Increases above 0.2%:
Increases (1 build for cc32xx)
Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Co-authored-by: Boris Zbarsky <[email protected]>
mkardous-silabs
force-pushed
the
feature/update_cm
branch
from
May 2, 2023 15:56
63fac64
to
b5df641
Compare
PR #26302: Size comparison from 7be1954 to b5df641 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
PR #26302: Size comparison from 7be1954 to e8f2ced Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
bzbarsky-apple
approved these changes
May 2, 2023
src/app/zap-templates/zcl/data-model/chip/client-monitoring-cluster.xml
Outdated
Show resolved
Hide resolved
PR #26302: Size comparison from 7be1954 to cb8af0c Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR updates the client monitoring cluster xml to match the cm cluster spec update
https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/6482