Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Removing a GroupKeySet does not removing the corresponding mapping #23862

Closed
cecille opened this issue Dec 1, 2022 · 0 comments · Fixed by #23864
Closed

[BUG] Removing a GroupKeySet does not removing the corresponding mapping #23862

cecille opened this issue Dec 1, 2022 · 0 comments · Fixed by #23864

Comments

@cecille
Copy link
Contributor

cecille commented Dec 1, 2022

Reproduction steps

- label: "TH sends KeySetWrite command with TH key"
      cluster: "Group Key Management"
      endpoint: 0
      command: "KeySetWrite"
      arguments:
        values:
            - name: GroupKeySet
              value: {
                        GroupKeySetID: 0x01a3,
                        GroupKeySecurityPolicy: 0,
                        EpochKey0: "0xd0d1d2d3d4d5d6d7d8d9dadbdcdddedf",
                        EpochStartTime0: 2220000,
                        EpochKey1: "0xd1d1d2d3d4d5d6d7d8d9dadbdcdddedf",
                        EpochStartTime1: 2220001,
                        EpochKey2: "0xd2d1d2d3d4d5d6d7d8d9dadbdcdddedf",
                        EpochStartTime2: 2220002,
                     }
    - label: "TH binds GroupId to GroupKeySet"
      cluster: "Group Key Management"
      endpoint: 0
      command: "writeAttribute"
      attribute: "GroupKeyMap"
      arguments:
        value: [
                  {
                    FabricIndex: 1,
                    GroupId: 0x0103,
                    GroupKeySetID: 0x01a3,
                  },
               ]

    - label: "TH removes the GroupKeySet"
      cluster: "Group Key Management"
      endpoint: 0
      command: "KeySetRemove"
      arguments:
        values:
          - name: GroupKeySetID
            value: 0x01a3

    - label: "TH verifies the corresponding GroupKeyMap entry has been removed"
      cluster: "Group Key Management"
      endpoint: 0
      command: "readAttribute"
      attribute: "GroupKeyMap"
      response:
        value: []

Bug prevalence

always

GitHub hash of the SDK that was being used

0493fc3 (ToT dec 1)

Platform

core

Platform Version(s)

No response

Anything else?

SDK problem is in the GroupDataProviderImpl. Will make changes before submitting changes to SC test plans / automation.

cecille added a commit to cecille/connectedhomeip that referenced this issue Dec 1, 2022
Per Core spec 11.2.9.4, If there exist any entries for the accessing
fabric within the GroupKeyMap attribute that refer to the
GroupKeySetID just removed, then these entries SHALL be removed from
that list.

Fixes project-chip#23862
cecille added a commit to cecille/connectedhomeip that referenced this issue Dec 22, 2022
Per Core spec 11.2.9.4, If there exist any entries for the accessing
fabric within the GroupKeyMap attribute that refer to the
GroupKeySetID just removed, then these entries SHALL be removed from
that list.

Fixes project-chip#23862
lecndav pushed a commit to lecndav/connectedhomeip that referenced this issue Mar 22, 2023
* Remove GroupKeyMap entries for removed KeySet

Per Core spec 11.2.9.4, If there exist any entries for the accessing
fabric within the GroupKeyMap attribute that refer to the
GroupKeySetID just removed, then these entries SHALL be removed from
that list.

Fixes project-chip#23862

* Restyled by clang-format

* Restyled by prettier-yaml

* Update src/credentials/GroupDataProviderImpl.cpp

Co-authored-by: Boris Zbarsky <[email protected]>

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant