ChipDeviceController sendMessage defaults to sending over unsecured transport

[bhaskar-apple]

Problem

Looking at the code looks like ChipDeviceController::sendMessage defaults to sending over the unsecure channel if there is one

CHIP_ERROR ChipDeviceController::SendMessage(void * appReqState, PacketBuffer * buffer)
{
    CHIP_ERROR err = CHIP_NO_ERROR;

    VerifyOrExit(mRemoteDeviceId.HasValue(), err = CHIP_ERROR_INCORRECT_STATE);

    mAppReqState = appReqState;

    if (mUnsecuredTransport != NULL)
    {
        VerifyOrExit(IsConnected(), err = CHIP_ERROR_INCORRECT_STATE);
        // Unsecured transport does not use a MessageHeader, but the Transport::Base API expects one, so
        // let build an empty one for now.
        MessageHeader header;
        Transport::PeerAddress peerAddress = Transport::PeerAddress::BLE();
        err                                = mUnsecuredTransport->SendMessage(header, peerAddress, buffer);
    }
    else
    {
        VerifyOrExit(IsSecurelyConnected(), err = CHIP_ERROR_INCORRECT_STATE);
        err = mSessionManager->SendMessage(mRemoteDeviceId.Value(), buffer);
    }

Pankaj mentioned this code is temporary and will be removed once some rendezvous pieces land.
Filing this issue to make sure this is tracked explicitly.

Proposed Solution

Only use secure transport post pairing.

@vivien-apple @shana-apple

[issue-label-bot]

Issue-Label Bot is automatically applying the label bug to this issue, with a confidence of 0.80. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.