Securing Rendezvous messages #2658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vivien-apple
requested review from
andy31415,
BroderickCarlin,
bzbarsky-apple,
chrisdecenzo,
hawk248,
jelderton,
mspang,
pan-apple,
robszewczyk,
rwalker-apple,
sagar-apple and
saurabhst
as code owners
vivien-apple
force-pushed
the
Rendezvous_SecureMessage
branch
from
c191c77 to
da022e2
Compare
vivien-apple
force-pushed
the
Rendezvous_SecureMessage
branch
from
da022e2 to
f3872d7
Compare
rwalker-apple
approved these changes
Sep 15, 2020
sagar-apple
approved these changes
Sep 15, 2020
Comment on lines
+204
to
210
| if (err != CHIP_NO_ERROR) | ||
| { | ||
| mPairingInProgress ? OnPairingError(err) : OnRendezvousError(err); | ||
| } |
There was a problem hiding this comment.
Any reason not to follow suit and use the SuccessOrExit(err); and exit: design here?
There was a problem hiding this comment.
SuccessOrExit(err);
mPairingInProgress ? OnPairingError(err) : OnRendezvousError(err);
exit:
There was a problem hiding this comment.
Vivien's comment above applies
BroderickCarlin
approved these changes
Sep 16, 2020
andy31415
approved these changes
Sep 16, 2020
vivien-apple
force-pushed
the
Rendezvous_SecureMessage
branch
from
f3872d7 to
f9c7202
Compare
mspang
approved these changes
Sep 16, 2020
|
Fixes #2239 |
woody-apple
approved these changes
Sep 17, 2020
woody-apple
approved these changes
Sep 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Encrypt messages sent over Rendezvous
fixes #2219