Skip to content

Commit

Permalink
Don't sweat interactive mode in build_examples.sh
Browse files Browse the repository at this point in the history
As of 3340fc2 ("Switch from readline to editline (#20330)") there is
no longer an issue with respect to the availability of libreadline.
  • Loading branch information
mspang committed Jul 6, 2022
1 parent 64b179a commit af5074d
Showing 1 changed file with 1 addition and 7 deletions.
8 changes: 1 addition & 7 deletions scripts/build/build/targets.py
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,6 @@ def HostTargets():
builder.AppendVariant(name="clang", use_clang=True),
builder.AppendVariant(name="test", extra_tests=True),

builder.WhitelistVariantNameForGlob('no-interactive-ipv6only')
builder.WhitelistVariantNameForGlob('ipv6only')

for target in app_targets:
Expand All @@ -288,12 +287,7 @@ def HostTargets():
builder.targets.append(target)

for target in builder.AllVariants():
if cross_compile and 'chip-tool' in target.name and 'arm64' in target.name and '-no-interactive' not in target.name:
# Interactive builds will not compile by default on arm cross compiles
# because libreadline is not part of the default sysroot
yield target.GlobBlacklist('Arm crosscompile does not support libreadline-dev')
else:
yield target
yield target

# Without extra build variants
yield target_native.Extend('chip-cert', app=HostApp.CERT_TOOL)
Expand Down

0 comments on commit af5074d

Please sign in to comment.