Skip to content

Commit

Permalink
Make breadcrumb optional in network commissioning cluster commands. (#…
Browse files Browse the repository at this point in the history 
…17007)

* Make breadcrumb optional in network commissioning cluster commands.

It's optional in the spec.

* Address review comments

* Fix ZAP job
  • Loading branch information
@bzbarsky-apple @pull
bzbarsky-apple authored and pull[bot] committed Nov 8, 2023
1 parent a183845 commit 4412387
Show file tree
Hide file tree
Showing 28 changed files with 237 additions and 213 deletions.
12 changes: 6 additions & 6 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2075,34 +2075,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/bridge-app/bridge-common/bridge-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -588,34 +588,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/door-lock-app/door-lock-common/door-lock-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -985,34 +985,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/light-switch-app/light-switch-common/light-switch-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -877,34 +877,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/lighting-app/lighting-common/lighting-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -948,34 +948,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/lock-app/lock-common/lock-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -441,34 +441,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/log-source-app/log-source-common/log-source-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -232,34 +232,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/ota-provider-app/ota-provider-common/ota-provider-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -305,34 +305,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
12 changes: 6 additions & 6 deletions examples/ota-requestor-app/ota-requestor-common/ota-requestor-app.matter
View file
Original file line number Diff line number Diff line change
Expand Up @@ -278,34 +278,34 @@ server cluster NetworkCommissioning = 49 {

request struct ScanNetworksRequest {
OCTET_STRING ssid = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct AddOrUpdateWiFiNetworkRequest {
OCTET_STRING ssid = 0;
OCTET_STRING credentials = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

request struct AddOrUpdateThreadNetworkRequest {
OCTET_STRING operationalDataset = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct RemoveNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ConnectNetworkRequest {
OCTET_STRING networkID = 0;
INT64U breadcrumb = 1;
optional INT64U breadcrumb = 1;
}

request struct ReorderNetworkRequest {
OCTET_STRING networkID = 0;
INT8U networkIndex = 1;
INT64U breadcrumb = 2;
optional INT64U breadcrumb = 2;
}

response struct ScanNetworksResponse {
Expand Down
Loading

0 comments on commit 4412387

Please sign in to comment.