-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update anomaly detection app dependencies #672
update anomaly detection app dependencies #672
Conversation
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
Signed-off-by: Johnson Shih <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this is needed to make armv7 version to work, if so, as it's just a sample app I guess we can disable armv7 build for this one.
yes, but I'd like to fix the build first, we can disable armv7 build in a separate PR so in case we bring armv7 back in the future, it still works. |
Signed-off-by: Johnson Shih <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine for me, I still think the best way for a fix would be to just disable armv7 here.
As the only way to get back an armv7 build (if we switch to python
base image rather than debian + apt python) for this sample app would be to not depend on numpy and scikit (maybe we could use a simpler way than LOF for this, I'm not sure of the value of something that complex for a sample app).
But we can postpone that discussion and just fix the build for now
agree |
What this PR does / why we need it:
Add missing dependency to anomaly detection app, the python3-sklearn was removed accidentally in previous PR, the dependency is required or the application cannot run properly.
Also remove the version stamp for numpy and let the system picks proper version to use. Use numpy version 1.21.4 causes issues when building arm32v7 images. The build stuck at installing dependencies and never complete.
Special notes for your reviewer:
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)