Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node version in container build actions #671

Closed

Conversation

johnsonshih
Copy link
Contributor

@johnsonshih johnsonshih commented Oct 13, 2023

What this PR does / why we need it:
Recently we started to hit errors when building application containers, the error is due to the version of node.js (12) is too old, update to version 18 to get rid of the errors.

Special notes for your reviewer:
There is another issue that Build Anomaly Detection App Container / per-arch (arm32v7) job takes forever to complete. I'll address that in a separate PR.

If applicable:

  • this PR has an associated PR with documentation in akri-docs
  • this PR contains unit tests
  • added code adheres to standard Rust formatting (cargo fmt)
  • code builds properly (cargo build)
  • code is free of common mistakes (cargo clippy)
  • all Akri tests succeed (cargo test)
  • inline documentation builds (cargo doc)
  • all commits pass the DCO bot check by being signed off -- see the failing DCO check for instructions on how to retroactively sign commits

Signed-off-by: Johnson Shih <[email protected]>
@johnsonshih
Copy link
Contributor Author

already include in #672

@johnsonshih johnsonshih deleted the user/jshih/node-version branch October 20, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant