[FEAT] Add API to search elements by BPMN Kinds #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbouffard
added
enhancement
csouchet
reviewed
Dec 17, 2020
| @@ -35,8 +37,37 @@ export class BpmnElementsRegistry { | |||
| .filter(e => e) | |||
| .map(bpmnSemantic => ({ bpmnSemantic: bpmnSemantic, htmlElement: this.htmlElementRegistry.getBpmnHtmlElement(bpmnSemantic.id) })); | |||
| } | |||
|
|
|||
| getElementsByKinds(bpmnKinds: BpmnKind | BpmnKind[]): BpmnElement[] { | |||
tbouffard
commented
Dec 17, 2020
Comment on lines
68
to
61
| // TODO rename into BpmnElementKind (for consistency with argument of computeBpmnBaseClassName otherwise, rename the argt) | ||
| export type BpmnKind = FlowKind | ShapeBpmnElementKind; |
There was a problem hiding this comment.
I have decided to name it BpmnElementKind for consistency
tbouffard
force-pushed
the
927-get_bpmn_elements_by_bpmn_kinds
branch
from
7c749cf
to
3614bb8
Compare
tbouffard
changed the title
tbouffard
removed
the
WIP 🚧
tbouffard
commented
Dec 18, 2020
tbouffard
requested review from
a team,
csouchet and
aibcmars
and removed request for
a team
tbouffard
added
depends on another PR ⚠️
Let pass one or several BPMN Kinds to get BpmnElements. This implementation relies on CSS selectors for searching elements. It will be possible to avoid this when the BpmnModel will be available and will provide search capabilities. # Conflicts: # src/component/registry/bpmn-elements-registry.ts # Conflicts: # src/component/registry/bpmn-elements-registry.ts
Better exclude the label instead of using the hacky style attribute
tbouffard
force-pushed
the
927-get_bpmn_elements_by_bpmn_kinds
branch
from
3614bb8
to
e5b1bd9
Compare
|
Kudos, SonarCloud Quality Gate passed! |
tbouffard
removed
WIP 🚧
|
LGTM |
aibcmars
approved these changes
Dec 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let pass one or several BPMN Kinds to get BpmnElements.
This implementation relies on CSS selectors for searching elements. It will be
possible to avoid this when the BpmnModel will be available and will provide
search capabilities (see #953).
closes #927