Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] Keep the loaded BpmnModel into memory #953

Open
Tracked by #2471 ...
tbouffard opened this issue Dec 15, 2020 · 0 comments
Open
Tracked by #2471 ...

[REFACTOR] Keep the loaded BpmnModel into memory #953

tbouffard opened this issue Dec 15, 2020 · 0 comments
Labels
refactoring Code refactoring

Comments

@tbouffard
Copy link
Member

tbouffard commented Dec 15, 2020

Current situation
For #929, we need to get BPMN information: currently we used data from the mxgraph model, which implies parsing and make us very adherent to the rendering lib, whereas we may have to remove mxgraph (see #917)
We need search capabilities on top of the diagram, at least for #927 and #942: for now, at least by id and by bpmn kind (shape or edge).

In version 0.9.0 and earlier, the model is created on BPMN diagram load and only used for the rendering. Once this is done, we drop it and so it is not possible to use it afterwards.
We also have a DisplayedModel which is a view of the part of the diagram that is actually rendered. This DisplayedModel is ephemeral.
As of 0.12.2, we have a RenderedModel that is partially stored in memory as SearchableModel for elements search. See #1115

Proposal overview
Keep the BpmnModel into memory and add it search capabilities, directly or to an implementation allowing to search it.
Then uses it as replacement of mxGraph for BPMN info retrieval and of some CSS selectors.

Keeping the BpmnModel into memory would provide other opportunities:

Implementation proposals
TO be discussed

@tbouffard tbouffard added the refactoring Code refactoring label Dec 15, 2020
@tbouffard tbouffard added this to the 0.10.0 milestone Dec 15, 2020
@aibcmars aibcmars modified the milestones: 0.10.0, 0.11.0 Jan 11, 2021
@csouchet csouchet modified the milestones: 0.11.0, 0.12.0 Jan 25, 2021
@tbouffard tbouffard added the hacktoberfest Can be done during the Hacktoberfest label Sep 22, 2021
@tbouffard tbouffard removed the hacktoberfest Can be done during the Hacktoberfest label Sep 15, 2022
@csouchet csouchet moved this to Q1 in Roadmap 2023 Dec 14, 2022
@tbouffard tbouffard changed the title [REFACTOR] keep the loaded BpmnModel into memory [REFACTOR] Keep the loaded BpmnModel into memory Jan 20, 2023
@csouchet csouchet modified the milestones: 0.29.2, 0.29.3 Jan 23, 2023
@csouchet csouchet modified the milestones: 0.29.3, 0.30.1 Feb 6, 2023
@tbouffard tbouffard removed this from the 0.30.1 milestone Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Code refactoring
Projects
Status: Todo
Development

No branches or pull requests

3 participants