Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Provide an option to ignore BPMN Label Bounds of activities #2469

Open
Tracked by #2471
tbouffard opened this issue Jan 20, 2023 · 0 comments
Open
Tracked by #2471

[FEAT] Provide an option to ignore BPMN Label Bounds of activities #2469

tbouffard opened this issue Jan 20, 2023 · 0 comments
Labels
BPMN diagram styling Change the standard rendering: stroke color, thickness enhancement New feature or request
Milestone

Comments

@tbouffard
Copy link
Member

tbouffard commented Jan 20, 2023

Is your feature request related to a problem? Please describe.

In #2253 or #2590, we see that sometimes the label bounds in the BPMN diagram are not correctly set, so bpmn-visualization doesn't display inside of the activity bounds for instance.

Describe the solution you'd like

Pass an option at library initialization (like proposed in #1993) or at load time (with a new option in LoadOptions) to ignore the label bounds configuration defined in the BPMN diagram for activities.
We may also introduce an additional option to ignore the label bounds of tasks only. Ignoring the label bounds of expanded call activities and sub-processes can be problematic as inner elements may overlap with the default label position (even if the default "top center" label position should handle most of the cases).
Important: the name of the options have been decided in #2659

Additional context

We already have some visual tests for default label positions. As part of implementing the issue described here, we should review if we cover default label position for all BPMN activities. In particular, for call activity and sub-process, for both expanded/collapsed.
Labels for expanded activities should

  • not be centered as it contains elements
  • be placed on top center as an icon can be displayed (call activities)

See #2664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BPMN diagram styling Change the standard rendering: stroke color, thickness enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant