Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add visual tests for label of collapsed/expanded activities #2664

Merged
merged 3 commits into from
May 3, 2023

Conversation

tbouffard
Copy link
Member

@tbouffard tbouffard commented May 2, 2023

This tests the default label bounds. We have a special configuration for expanded sub-process and call activity that wasn't visually tested (the style configuration was already unit-tested).

covers #2469

This tests the default label bounds. We have a special configuration for expanded sub-process and call activity that
wasn't visually tested (the style configuration was already unit-tested).
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label May 2, 2023
@tbouffard tbouffard marked this pull request as ready for review May 3, 2023 13:48
@tbouffard tbouffard requested a review from csouchet May 3, 2023 13:48
Copy link
Member

@csouchet csouchet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted for the missing tests! 👍

@sonarcloud
Copy link

sonarcloud bot commented May 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@tbouffard tbouffard merged commit 9accbab into master May 3, 2023
@tbouffard tbouffard deleted the test/add_visu_test_label_of_expanded_activities branch May 3, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants