-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor flows module #24
Conversation
1d49e3f
to
601a309
Compare
* Split the flows module into many sub-modules * Rename {Distribution,Transform}Module to {Distribution,Transform}Factory * Spread the bisection bounds of monotonic transformations * New rotation transformation (RotationTransform) * New gaussianization transformation (GaussianizationTransform) * New gaussianization flow (GF)
601a309
to
facd1d3
Compare
Hey @simonschnake, I have updated the README in this PR, do you think the new introduction is good? Feel free to make comments on the PR, if you find the time. |
Hey @francois-rozet, I would change one sentence in the Another thing is spot was
Here you take as an example, to make the second layer a These are just small things. Overall, I think it is a very solid piece of work. |
62bc58a
to
1eae0aa
Compare
Thanks! I addressed your comments for the README. I will merge soon. |
The new API documentation is up at https://zuko.readthedocs.io/en/stable/api/zuko.flows.html 🔥 I think it is much more readable than before. I also added a few warnings about invertibility. Next step are tutorials. |
The
zuko/flows.py
file has become too long. It makes it hard to navigate the code and add new features. I think splitting the module into sub-modules would help greatly. This PR is a first attempt to refactor theflows
module.