-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tutorials #25
Comments
Hey @simonschnake, do you think of another tutorial that could be added? |
Hey @francois-rozet, I shortly looked into the examples of I am happy to help you in writing tutorials. |
These notebooks are good bases, but I think more explanations are necessary, at least for the "first" tutorial that would explain the core Zuko concepts. For instance, something like https://github.com/francois-rozet/lampe/blob/master/docs/tutorials/npe.ipynb . I'll write this first tutorial, and then we can add the others with a similar format. I will gladly accept your help! Also, I am planning to refactor the |
I think you are right. The way in which the forward pass of the TransformModule gives you a Transform is something not very common. A normal torch user would expect to get a tensor back. I don't know how backward compatible you want to stay. I think a clear naming split between the DistributionModule and TransformModule, and the dedicated DistributionFactory and TransformFactory, would be nice. In mathematics, a function that returns a function is called a functional. Maybe we could take that and call them Transformal and Distributional. The nice thing about including Factory at the end is that it is absolutely clear what the thing is doing. |
Let's go for |
Hello @simonschnake, I finally had the time to write the first tutorials. There has been a lot of changes (including transferring to the probabilists organization) since the last release. I think after we merge the tutorials PR (#27) we are ready to bump Zuko to version 1.0.0 🔥 If you have the time, could you read the tutorials (https://zuko.readthedocs.io/en/tutorials/tutorials.html) and give some feedback? 🙏 |
Description
The documentation should provide tutorials for common use cases, such as creating a custom (coupling/autoregressive) flow, training with the forward and backward KL, performing importance sampling, adding preprocessing transformations, and maybe training a CNF with a flow-matching loss.
These tutorials can be Jupyter notebooks and can either be included in the documentation with
myst-nb
or linked from the repository.The text was updated successfully, but these errors were encountered: