Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable/disable File Watcher setting + commands #1001

Merged
merged 3 commits into from
Dec 22, 2021
Merged

feat: enable/disable File Watcher setting + commands #1001

merged 3 commits into from
Dec 22, 2021

Conversation

Jolg42
Copy link
Contributor

@Jolg42 Jolg42 commented Dec 21, 2021 •
edited
Loading

Closes #944

Implemented as a boolean
Screen Shot 2021-12-21 at 13 04 46
Shows in the UI like
Screen Shot 2021-12-21 at 13 04 14
With commands to set it on/off easily
Screen Shot 2021-12-21 at 13 03 51

@Jolg42 Jolg42 added this to the 3.8.0 milestone Dec 21, 2021
@Jolg42 Jolg42 requested review from janpio and tomhoule December 21, 2021 11:59
@Jolg42 Jolg42 marked this pull request as ready for review December 21, 2021 11:59
janpio
janpio reviewed Dec 21, 2021
View reviewed changes
packages/vscode/package.json
Comment on lines -87 to +93
"description": "Traces the communication between VS Code and the language server."
"description": "Setting for logging between the VS Code extension and the language server."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it's even implemented after a quick check 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it's a native thing https://code.visualstudio.com/api/language-extensions/language-server-extension-guide#logging-support-for-language-server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for you?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add that as a comment here, so next time we don't have similar questions again - then this should be good.

tomhoule
tomhoule approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@tomhoule tomhoule left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/language-server/src/server.ts Show resolved Hide resolved
janpio
janpio approved these changes Dec 21, 2021
View reviewed changes
Copy link
Contributor

@janpio janpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having extensions build for branches would be really neat, so we could test that easily... A .vsix file would probably be enough to download and install manually.

@Jolg42
Copy link
Contributor Author

Jolg42 commented Dec 22, 2021

Indeed it would be a much better experience to review/test in branches
Created an issue #1005

@Jolg42 Jolg42 merged commit 5f3585e into main Dec 22, 2021
@Jolg42 Jolg42 deleted the joel/file-watcher-config branch December 22, 2021 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomhoule tomhoule tomhoule approved these changes

@janpio janpio janpio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.0
Development

Successfully merging this pull request may close these issues.

Add configuration option to turn off file watcher
3 participants
@Jolg42 @janpio @tomhoule