Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration option to turn off file watcher #944

Closed
janpio opened this issue Nov 16, 2021 · 3 comments · Fixed by #1001
Closed

Add configuration option to turn off file watcher #944

janpio opened this issue Nov 16, 2021 · 3 comments · Fixed by #1001
Assignees
@Jolg42
Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/feature A request for a new feature. topic: file watching
Milestone
3.8.0

Comments

@janpio
Copy link
Contributor

janpio commented Nov 16, 2021

File watcher is causing problems we can not figure out, so let's build in a switch to turn it off and see if this fixes problems for users.
@janpio janpio added kind/feature A request for a new feature. process/candidate Candidate for next Milestone. labels Nov 16, 2021
@Jolg42 Jolg42 added the domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. label Nov 16, 2021
@tomhoule tomhoule changed the title Add configuration option to turn of file watcher Add configuration option to turn off file watcher Nov 17, 2021
@janpio
Copy link
Contributor Author

janpio commented Nov 25, 2021

Code for settings reading etc might have been removed as part of #950 (review)

@Jolg42 Jolg42 removed the process/candidate Candidate for next Milestone. label Dec 1, 2021
@Jolg42 Jolg42 added this to the 3.7.0 milestone Dec 1, 2021
@Jolg42 Jolg42 self-assigned this Dec 1, 2021
Jolg42 added a commit that referenced this issue Dec 21, 2021
@Jolg42
feat: enable/disable File Watcher setting + commands
13e526e 
Closes #944
@Jolg42 Jolg42 mentioned this issue Dec 21, 2021
Merged
@Jolg42 Jolg42 modified the milestones: 3.7.0, 3.8.0 Dec 21, 2021
@Jolg42
Copy link
Contributor

Jolg42 commented Jan 12, 2022

I'll ping the different issues with this in a bit

This was referenced Jan 12, 2022
Closed
Closed
Closed
Closed
@Jolg42
Copy link
Contributor

Jolg42 commented Jan 12, 2022

Since version 3.8.0 of the Prisma VS Code extension released yesterday there is now a way to disable the File Watcher.

It's implemented as a (default = true) boolean in the settings
Screen Shot 2021-12-21 at 13 04 46
Screen Shot 2021-12-21 at 13 04 14

And can be enabled/disabled from the command palette UI like this
Screen Shot 2021-12-21 at 13 03 51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jolg42 Jolg42

Labels
domain/schema Issue in the "Schema" domain: Prisma Schema, Introspection, Migrations etc. kind/feature A request for a new feature. topic: file watching
Projects
None yet
Milestone
3.8.0
Development

Successfully merging a pull request may close this issue.

feat: enable/disable File Watcher setting + commands prisma/language-tools
2 participants
@janpio @Jolg42