Adds clear all button in header using the FilterRemoveIcon Octicon #3778
Conversation
|
size-limit report 📦
|
UnicodeRogue
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Co-authored-by: Gregor Martynus <[email protected]>
UnicodeRogue
temporarily deployed
to
github-pages
GitHub Actions
Inactive
examples/nextjs/package-lock.json
Outdated
There was a problem hiding this comment.
I'm not sure where the changes to examples/nextjs/package-lock.json came from. As far as I can tell we just ran npm install in the project root. Should we get the change removed from the PR?
There was a problem hiding this comment.
Oh I'm okay to remove any changes 🙇🏻 You're right, what I know we didn't specifically work on I was thinking was coming through from the npm install/any updates around that
There was a problem hiding this comment.
I don't think this is your fault, see #3776
| @@ -1,5 +1,5 @@ | |||
| import React from 'react' | |||
| import {SearchIcon, XCircleFillIcon, XIcon} from '@primer/octicons-react' | |||
| import {SearchIcon, XCircleFillIcon, XIcon, FilterRemoveIcon} from '@primer/octicons-react' | |||
| @@ -773,6 +773,64 @@ export const GOpenFromMenu = () => { | |||
| ) | |||
| } | |||
|
|
|||
| export const IWithRemoveFilterIcon = () => { | |||
There was a problem hiding this comment.
Just checking, do we want to keep this story because clearSelection is also present in other stories
There was a problem hiding this comment.
I believe so? If only because it will be easy to take out later if we want 🙇🏻
| @@ -16,7 +16,7 @@ | |||
| "@lit-labs/react": "^1.1.1", | |||
| "@oddbird/popover-polyfill": "0.2.2", | |||
| "@primer/behaviors": "^1.3.4", | |||
| "@primer/octicons-react": "^19.7.0", | |||
| "@primer/octicons-react": "19.8.0", | |||
There was a problem hiding this comment.
Kinda odd that the lock file doesn't have a caret ^ anymore even though package.json does?
There was a problem hiding this comment.
not having a ^ was the suggested format when I ran updates, but I agree that the lines read a bit weird. I'm going to pull in any recent changes and see if that resolves things
UnicodeRogue
temporarily deployed
to
github-pages
GitHub Actions
Inactive
UnicodeRogue
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
All right, working through the last few bits here- I do see three currently failing CI tests, mostly about ActionList- I wonder if this is something we can take out? 
|
|
Uh oh! @UnicodeRogue, the image you shared is missing helpful alt text. Check #3778 (comment). Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. |
There was a problem hiding this comment.
this changes was necessary to address https://github.com/primer/react/actions/runs/6449351303/job/17507571046?pr=3778
Closes #2399
Changelog
New
No new files added, did add a new story, called
I With Remove Filter IconChanged
Imported visual button
FilterRemoveIconand created the functionality to clear items selected in the drop-down listRemoved
One file was removed, the temporary icon that was a placeholder until the official Octicon one
Rollout strategy
Testing & Reviewing
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.