Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update lockfiles #3776

Closed
wants to merge 1 commit into from
Closed

Update lockfiles #3776

wants to merge 1 commit into from

Conversation

iansan5653
Copy link
Contributor

Updates package-lock.json files so they aren't always changed when creating a new Codespace. Codespaces run npm install on create, so the lockfiles are out of date and I don't want to commit them while working on other things.

@iansan5653 iansan5653 requested review from a team and siddharthkp September 27, 2023 17:42
@changeset-bot

This comment was marked as resolved.

@iansan5653 iansan5653 added the skip changeset This change does not need a changelog label Sep 27, 2023
@iansan5653 iansan5653 self-assigned this Sep 27, 2023
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
dist/browser.esm.js 104.36 KB (0%)
dist/browser.umd.js 104.94 KB (0%)

@iansan5653
Copy link
Contributor Author

wierd...so the CI job is failing because npm ci fails because the lockfile is out of date. But the lockfile is being updated after the codespace installs dependencies. 🤔 Maybe we need to use npm ci in the devcontainer setup?

@joshblack
Copy link
Member

@iansan5653 oh weird, totally see what you're saying 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants