Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to a ES Module (blocked on next-major) #2354

Closed
wants to merge 12 commits into from
+97 −4,512
Closed

Convert to a ES Module (blocked on next-major) #2354

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
0049818
Make package a module
koddsson Sep 20, 2022
0848c70
Fix file extension on commonjs files
koddsson Sep 20, 2022
06df78e
Update theme files to use commonjs extensions
koddsson Sep 20, 2022
9383d55
Only output ESM
koddsson Sep 20, 2022
1cb01f0
Update themepreval snapshot
koddsson Sep 20, 2022
a21908b
Fix file extension on storybook files
koddsson Sep 20, 2022
5c1eee9
Add a changeset file
koddsson Sep 20, 2022
1bcf4c8
Fix more imports
koddsson Sep 20, 2022
83d8a4b
Add extension to require statement
koddsson Sep 28, 2022
1378be6
Actually output UMD again so the PR is smaller
koddsson Sep 28, 2022
e4a15d6
Update snapshots
koddsson Sep 29, 2022
70f3db0
Merge branch 'main' of github.com:primer/react into esm
koddsson Sep 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/early-dodos-heal.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@primer/react': major
---

Convert package to a ES module
0 .storybook/main.js → .storybook/main.cjs
View file
Open in desktop
File renamed without changes.
0 .storybook/preview.js → .storybook/preview.cjs
View file
Open in desktop
File renamed without changes.
0 babel-defines.js → babel-defines.cjs
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion babel.config.js → babel.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const defines = require('./babel-defines')
const defines = require('./babel-defines.cjs')

function replacementPlugin(env) {
return ['babel-plugin-transform-replace-expressions', {replace: defines[env]}]
Expand Down
2 changes: 1 addition & 1 deletion docs/gatsby-node.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const defines = require('../babel-defines')
const defines = require('../babel-defines.cjs')
const docgen = require('react-docgen-typescript')
const globby = require('globby')

Expand Down
0 jest.config.js → jest.config.cjs
View file
Open in desktop
File renamed without changes.
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
"description": "An implementation of GitHub's Primer Design System using React",
"main": "lib/index.js",
"module": "lib-esm/index.js",
"type": "module",
"exports": {
".": {
"import": "./lib-esm/index.js",
Expand Down
Loading