Convert to a ES Module (blocked on next-major) #2354
Conversation
🦋 Changeset detectedLatest commit: 70f3db0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| "var module = { | ||
| exports: {} | ||
| }; | ||
| var exports = module.exports; | ||
| // this file was prevaled | ||
| // This file needs to be a JavaScript file using CommonJS to be compatible with preval | ||
| // Cache bust: 2022-07-25 12:00:00 GMT (This file is cached by our deployment tooling, update this timestamp to rebuild this file) |
There was a problem hiding this comment.
I don't know what preval is so I don't know what to do about this.
|
Hey @koddsson! 👋 Wanted to follow-up on this real quick 👀 It seems like this kind of change will need to be slated to the next major release (v36) and I've added it over to the proposals here: https://github.com/github/primer/issues/1294 As a result, it might be better to revisit it closer to the next major release as I'm not sure if changes can be merged before then. Hope this makes sense! Let me know if you have any questions |
siddharthkp
changed the title
siddharthkp
changed the title
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days. |
|
Hi there! 👋 Just wanted to say thanks again for the taking the time to work on this, we picked it up and are building on it over in: #3410 Going to close this out as a result, let me know if you have any questions! Thanks again 🙏 |
Describe your changes here.
Convert
primer/reactto a ES Module.Screenshots
N/A
Merge checklist