Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Caret with emotion #184

Closed
wants to merge 7 commits into from
Closed

Update Caret with emotion #184

Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0545654
update caret
Aug 3, 2018
dea267b
Merge branch 'release-1.0.0-beta' of github.com:primer/primer-react i…
Aug 6, 2018
1c7f1f7
update snaps 2
Aug 6, 2018
9bc8078
add system props to Caret
Aug 6, 2018
cb3b26b
remove withSystemProps
Aug 7, 2018
7e34256
update snaps
Aug 7, 2018
23c8e64
use withSystemProps lol
Aug 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Caret.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ function Caret(props) {
}[edge]

return (
<svg width={size * 2} height={size * 2} style={style}>
<svg width={size * 2} height={size * 2} style={style} className={props.className}>
<g transform={transform}>
<path d={triangle} fill={bg} />
<path d={line} fill="none" stroke={borderColor} strokeWidth={borderWidth} />
Expand Down Expand Up @@ -120,4 +120,4 @@ Caret.propTypes = {
/* eslint-enable */
}

export default withDefaultTheme(Caret)
export default withSystemProps(withDefaultTheme(Caret))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: withSystemProps() calls withDefaultTheme() for us ✨

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! So I removed withSystemProps and now it's just withDefaultTheme(Caret, COMMON) and the toImplementSystemProps test is failing 🤔

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow I see what I did there 😂 Ignore me, I'm drinking coffee as we speak hahaha