Update Caret with emotion #184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emplums
commented
Aug 3, 2018
| @@ -24,15 +29,20 @@ exports[`Caret renders cardinal directions 1`] = ` | |||
| <path | |||
| d="M-8,0L0,8L8,0" | |||
| fill="none" | |||
| stroke="#e1e4e8" | |||
| stroke="#000" | |||
Merged
added 2 commits
August 6, 2018 15:24
shawnbot
reviewed
Aug 6, 2018
src/Caret.js
Outdated
| @@ -120,4 +120,4 @@ Caret.propTypes = { | |||
| /* eslint-enable */ | |||
| } | |||
|
|
|||
| export default withDefaultTheme(Caret) | |||
| export default withSystemProps(withDefaultTheme(Caret)) | |||
There was a problem hiding this comment.
FYI: withSystemProps() calls withDefaultTheme() for us ✨
There was a problem hiding this comment.
Hey! So I removed withSystemProps and now it's just withDefaultTheme(Caret, COMMON) and the toImplementSystemProps test is failing 🤔
There was a problem hiding this comment.
Oh wow I see what I did there 😂 Ignore me, I'm drinking coffee as we speak hahaha
36 tasks
added 2 commits
August 7, 2018 08:10
|
We decided it's silly to add system props to Caret since it should only be used in CaretBox, closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR gives the system props to the Caret component.
I started making this PR, but once I was done I realized that maybe Caret doesn't need system props, since it's only supposed to be an internal component used by CaretBox? Thoughts?