-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed react 19 errors #690
Conversation
🦋 Changeset detectedLatest commit: 49ae5c0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🟢 No design token changes found |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Do you think it's worth bumping our Next.js integration test to use the Next 15 RC so we can keep an eye on React 19 compatibility in the pipelines? Once Next 15 reaches GA we can revert so we're not constantly tracking an RC.
The current Next.js test is still valid, and arguably more important than the RC as we need to ensure compat with latest stable Next.js. We could create a second integration test though specifically for React 19, and use Next.js RC as the mechanism to verify. That's a good shout, I'll take a look later this week. |
Summary
Fixes major bug with React 19 release candidate, which is causing errors in dotcom when using React Next FF.
Makes parts of
react-dom
full externals of the library, to prevent conflict in React 19+/What should reviewers focus on?
Steps to test:
Contributor checklist:
Reviewer checklist:
Screenshots:
Fixed and tested in Next.js RC