fixed react 19 errors (#690)

* fixed react 19 errors * add changeset * remove previous changeset * fix typo
primer · Sep 2, 2024 · 98fa3a2 · 98fa3a2
1 parent aff5874
commit 98fa3a2
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 10 deletions.
diff --git a/.changeset/late-badgers-lay.md b/.changeset/late-badgers-lay.md
@@ -0,0 +1,5 @@
+---
+'@primer/react-brand': minor
+---
+
+Improved React 19 compatibility by treating `react-dom/client` and `react/jsx-runtime` as external dependencies of the project. This change resolved a reported conflict with the latest React 19 release candidate.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -80,8 +80,8 @@
     "webpack-cli": "^4.10.0"
   },
   "peerDependencies": {
-    "react": ">=17 <= 18",
-    "react-dom": ">=17 <= 18"
+    "react": ">=17 <20",
+    "react-dom": ">=17 <20"
   },
   "engines": {
     "node": ">=16.0.0",

diff --git a/packages/react/webpack.config.js b/packages/react/webpack.config.js
@@ -17,11 +17,25 @@ module.exports = {
       root: 'React',
       commonjs2: 'react',
       commonjs: 'react',
+      amd: 'react',
     },
     'react-dom': {
       root: 'ReactDOM',
       commonjs2: 'react-dom',
       commonjs: 'react-dom',
+      amd: 'react-dom',
+    },
+    'react-dom/client': {
+      root: 'ReactDOMClient',
+      commonjs2: 'react-dom/client',
+      commonjs: 'react-dom/client',
+      amd: 'react-dom/client',
+    },
+    'react/jsx-runtime': {
+      root: 'ReactJSXRuntime',
+      commonjs2: 'react/jsx-runtime',
+      commonjs: 'react/jsx-runtime',
+      amd: 'react/jsx-runtime',
     },
   },
   mode: 'production',