Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #3443: Datatable: RowReorder fails in case of pagination on page other than first & last #3502

Merged
merged 1 commit into from
Jan 27, 2023

Conversation

FlipWarthog
Copy link
Contributor

@FlipWarthog FlipWarthog commented Jan 7, 2023

This fixes #3443.

I did not update the Reorder demo, but if you add :paginator="true" :rows="5" to it you can confirm the issue and subsequent fix. Also tested on the existing Reorder demo without pagination and it works there as well.

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@tugcekucukoglu tugcekucukoglu merged commit 4998bb7 into primefaces:master Jan 27, 2023
@FlipWarthog FlipWarthog deleted the PV3443 branch February 20, 2023 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datatable: RowReorder fails in case of pagination on page other than first & last
3 participants