Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datatable: RowReorder fails in case of pagination on page other than first & last #3443

Closed
melloware opened this issue Dec 23, 2022 · 0 comments · Fixed by #3502
Closed

Datatable: RowReorder fails in case of pagination on page other than first & last #3443

melloware opened this issue Dec 23, 2022 · 0 comments · Fixed by #3502
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.23.0

Comments

@melloware
Copy link
Member

Describe the bug

Originally reported at PrimeReact but it looks like PrimeVue has the identical code.

Issue: primefaces/primereact#3817

PR: primefaces/primereact#3818

I'm working on DataTable component, per my requirement I need to use reordering with pagination, but reordering is failing on page otherthan first & last.

Reproducer

https://codesandbox.io/s/lingering-leftpad-2hwboj

PrimeVue version

Latest

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@melloware melloware added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 23, 2022
@melloware melloware changed the title Component Name: Issue Title Datatable: RowReorder fails in case of pagination on page other than first & last Dec 23, 2022
FlipWarthog added a commit to FlipWarthog/primevue that referenced this issue Jan 7, 2023
@FlipWarthog
Fix primefaces#3443: Datatable: RowReorder fails in case of paginatio…
7289eb8 
…n on page other than first & last
@FlipWarthog FlipWarthog mentioned this issue Jan 7, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 27, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.23.0 milestone Jan 27, 2023
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 27, 2023
tugcekucukoglu added a commit that referenced this issue Jan 27, 2023
@tugcekucukoglu
Merge pull request #3502 from FlipWarthog/PV3443
4998bb7 
Fix #3443: Datatable: RowReorder fails in case of pagination on page other than first & last
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.23.0
2 participants
@melloware @tugcekucukoglu