Fix: Prevent overlay closing if click start inside #1361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cagataycivici
added
the
Type: Bug
|
Good catch, thanks! |
shadoWalker89
added a commit
to shadoWalker89/primevue
that referenced
this pull request
Sep 9, 2021
Hi, On this PR primefaces#1361 the event used for checking if the click is inside the overlay was changed from @click to @mousedown This caused the overlay to hide when clicking on a <label> tag within the overlay In this PR, i'm adding a listener for the click event that calls onContentClick function I tested this change locally and now both clicking on a label or trying to select text work both fine
mertsincan
pushed a commit
that referenced
this pull request
Sep 14, 2021
…nside (#1527) Hi, On this PR #1361 the event used for checking if the click is inside the overlay was changed from @click to @mousedown This caused the overlay to hide when clicking on a <label> tag within the overlay In this PR, i'm adding a listener for the click event that calls onContentClick function I tested this change locally and now both clicking on a label or trying to select text work both fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defect Fixes
When I try to highlight some text inside the overlay, if the cursor ends its run outside, the panel will be close.
I checked the code, and I found that "selfClick" property is used to avoid that, but I think It's attached to the wrong event.
I changed "click" event with "mousedown".