Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlay panel hide when clicking on a label inside of it #1528

Closed
shadoWalker89 opened this issue Sep 9, 2021 · 0 comments · Fixed by #1527
Closed

Overlay panel hide when clicking on a label inside of it #1528

shadoWalker89 opened this issue Sep 9, 2021 · 0 comments · Fixed by #1527
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.7.2

Comments

@shadoWalker89
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

CodeSandbox Case (Bug Reports)
https://codesandbox.io/s/wonderful-agnesi-020nn

Current behavior
When clicking on the label inside of the overlay it hides

Expected behavior
When clicking on the label inside of the overlay the overlay should not hide

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Please tell us about your environment:

  • Vue version: 3.X
  • PrimeVue version: 3.4.X
  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
@shadoWalker89 shadoWalker89 mentioned this issue Sep 9, 2021
Merged
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Sep 14, 2021
@mertsincan mertsincan changed the title [Bug] Overlay panel hide when clicking on a label inside of it Overlay panel hide when clicking on a label inside of it Sep 14, 2021
@mertsincan mertsincan added this to the 3.7.2 milestone Sep 14, 2021
mertsincan pushed a commit that referenced this issue Sep 14, 2021
@shadoWalker89
Fixed #1528 - Prevent overlay from closing when clicking on a label i…
121054c 
…nside (#1527)

Hi,
On this PR #1361 the event used for checking if the click is inside the overlay was changed from @click to @mousedown
This caused the overlay to hide when clicking on a <label> tag within the overlay

In this PR, i'm adding a listener for the click event that calls onContentClick function

I tested this change locally and now both clicking on a label or trying to select text work both fine
@mcandu mcandu mentioned this issue Sep 21, 2021
Closed
@yigitfindikli yigitfindikli mentioned this issue Sep 21, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.7.2
Development

Successfully merging a pull request may close this issue.

[Fix] Prevent overlay from closing when clicking on a label inside shadoWalker89/primevue
3 participants
@cagataycivici @shadoWalker89 @mertsincan