Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConfirmDialog: Unstyled mode is not implemented #5837

Closed
zawasp opened this issue Jan 25, 2024 · 13 comments
Closed

ConfirmDialog: Unstyled mode is not implemented #5837

zawasp opened this issue Jan 25, 2024 · 13 comments
Assignees
Labels
Component: NextJS NextJS related issue Component: Tailwind Tailwind specific issue
Milestone

Comments

@zawasp
Copy link
Contributor

zawasp commented Jan 25, 2024

Describe the bug

Comparing the ConfirmPopup code with ConfirmDialog, the code which takes into account unstyled mode is missing completely.

10.5.0

React version

18.x

Language

TypeScript

Build / Runtime

Next.js

Browser(s)

No response

Steps to reproduce the behavior

Expected behavior

Unstyled mode can be applied.

@zawasp zawasp added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 25, 2024
@melloware melloware added Component: Tailwind Tailwind specific issue Component: NextJS NextJS related issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 25, 2024
@zawasp
Copy link
Contributor Author

zawasp commented Feb 5, 2024

Any updates on this one?

@melloware
Copy link
Member

Any investigation or PR is welcome!

@zawasp
Copy link
Contributor Author

zawasp commented Feb 7, 2024

@melloware it seems ConfirmDialog doesn't use unstyled mode at all. Just comparing ConfirmPopup and ConfirmDialog code, there's nothing related to it.

@melloware
Copy link
Member

Agreed.

@zawasp
Copy link
Contributor Author

zawasp commented Feb 7, 2024

I'll edit the title and description then, to reflect the new finding.

@zawasp zawasp changed the title ConfirmDialog: Warning causes hydration error in NextJS + Tailwind ConfirmDialog: Unstyled mode is not implemented Feb 7, 2024
@melloware
Copy link
Member

@kl-nevermore i thought you fixed ConfirmDialog in this ticket: #5656

@melloware
Copy link
Member

@zawasp want to submit a PR?

@zawasp
Copy link
Contributor Author

zawasp commented Feb 8, 2024

I would if I could start the dev build of primereact so I can debug properly.

@zawasp
Copy link
Contributor Author

zawasp commented Feb 10, 2024

@

@kl-nevermore
Copy link
Contributor

@kl-nevermore i thought you fixed ConfirmDialog in this ticket: #5656

I forgot to check if unstyled mode is implemented, I will recheck the previous changes are unnecessary

@kl-nevermore
Copy link
Contributor

checked
These two are different issues

@melloware
Copy link
Member

Yep we have updated confirm dialog in the latest version and added the new styles

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: NextJS NextJS related issue Component: Tailwind Tailwind specific issue
Projects
None yet
Development

No branches or pull requests

3 participants