ConfirmDialog：confirmDialog method in unstyled mode, the pop-up window style not apply

[shenpvip]

Describe the bug

confirmDialog method in unstyled mode, the pop-up window style does not apply

Reproducer

https://stackblitz.com/edit/react-hzzvhp?file=src%2Findex.js,src%2FApp.js

PrimeReact version

10.2.1

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

[kl-nevermore]

Should confirmProps and props be merged?
like...

const getCurrentProps = () => Object.assign(props,confirmProps.current)
const getPropValue = (key) => Object.assign(props,confirmProps.current)[key];

[melloware]

@kl-nevermore is this still happening in the main branch? I thought I had fixed this before when someone reported it but i could be wrong?

[kl-nevermore]

@melloware
I just tested in main branch
It seems like only the buttons work

[melloware]

OK then I definitely did not fix it 😄

[kl-nevermore]

After merging props, it can work, but I'm not sure if it's the correct solution

[melloware]

well submit a PR please I can take a look.

[melloware]

Actually I think this PR addresses the ConfirmDialog issue.

#5215

Can you review?

[kl-nevermore]

Still can not

[kl-nevermore]

1. the pt passed to root is currentProps.pt
2. the currentProps from getCurrentProps
3. getCurrentProps return confirmProps.current || props
4. confirmProps.current from confirm's arguments
5. when invoke confirmDialog,the confirmDialog's arguments as props
6. lost the component's props?

[melloware]

@kl-nevermore i just tried your sandbox with 10.3.0 and it has the same issue?

https://stackblitz.com/edit/react-hzzvhp-6btcgt?file=src%2Findex.js,src%2FApp.js

[melloware]

Had to revert this fix it broke the showcase.

[kl-nevermore]

@melloware
I just tested use tag 10.2.1, I guess it had some impact.

[melloware]

OK well if you try with the current showcase you will see the issue I am seeing if you want to take another look!

[kl-nevermore]

I found #5401 was rolled back and many other changes were also lost in 10.3.0

[melloware]

@kl-nevermore let's revisit this now that the main branch is up to date.

[kl-nevermore]

@melloware
I'll follow up today

[kl-nevermore]

like unstyled, passed props.pt to Dialog

const rootProps = mergeProps(
    {
        visible: visibleState,
        className: classNames(getPropValue('className'), cx('root')),
        footer,
        onHide: hide,
        breakpoints: getPropValue('breakpoints'),
+       pt: props.pt,
-       pt: currentProps.pt
        unstyled: props.unstyled,
        appendTo: getPropValue('appendTo'),
        __parentMetadata: {
            parent: metaData
        }
    },
    ConfirmDialogBase.getOtherProps(currentProps)
);

[kl-nevermore]

If modify it as before, will throw #5767
feeling a little confused, When we use the confirmPopup method, should respect args instead of props?

If not use args,when multiple instances, we don't know which one to use

[melloware]

I thought only one confirm dialog could be on the screen at once? But I guess the could be stacked but from a UI perspective only 1 confirm dialog at a time makes more sense to me.

[melloware]

OK I have fixed #5770 so this should allow you to continue

[melloware]

The latest fixes have been applied in 10.5.1