Component: ConfirmDialog doesn't render buttons (v18.0.0-rc.1)

[honboubao]

Describe the bug

The confirm dialog doesn't show the Yes and No buttons.

This can be observed on the beta.3 example page as well https://v18.primeng.org/confirmdialog

The debug console points to an recursion error:

Environment

Windows 10
Firefox 128.3.1esr

Reproducer

No response

Angular version

18.2.9

PrimeNG version

18.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

22.4.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

[honboubao]

I don't think commit 089a01d really addresses the issue. With that change, it will basically always render the default buttons, even if a custom footer is provided, in the latter case it would render both.

I think the issue arises with <ng-template #footer> defining footer as a reference which clashes with @ContentChild(Footer) footer: Nullable<TemplateRef<any>> so I would suggest renaming the variable name of the latter.

The @else if that's been modified in the commit can then be reverted or replaced with a simple @else.

The error with the recursion seems to be a separate issue that arises, when there's nothing in the footer, that's focusable. When I provide a custom footer template containing only text, it shows the same error. If a add a button to the template, it doesn't show the error. This problem should probably be addressed in primeng-dialog focus()