Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: ConfirmDialog focus recursion error (v18.0.0) #17001

Closed
honboubao opened this issue Dec 10, 2024 · 0 comments
Closed

Component: ConfirmDialog focus recursion error (v18.0.0) #17001

honboubao opened this issue Dec 10, 2024 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@honboubao
Copy link

Describe the bug

Referring back to my previously submitted issue #16780 and the comment added after its closing.

The same error can be seen in the console as in the previous issue's screenshot.

The error with the recursion seems to be a separate issue that arises, when there's nothing in the footer, that's focusable. When I provide a custom footer template containing only text, it shows the same error. If a add a button to the template, it doesn't show the error. This problem should probably be addressed in primeng-dialog focus()

Environment

Windows 10
Firefox 128.3.1esr

Reproducer

https://stackblitz.com/edit/stackblitz-starters-tvktgjmx?file=src%2Fapp%2Fapp.component.html

Angular version

18.2.7

PrimeNG version

18.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.20.3

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@honboubao honboubao added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 10, 2024
@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 11, 2024
@mertsincan mertsincan added this to the 18.0.1 milestone Dec 11, 2024
@github-project-automation github-project-automation bot moved this to Review in PrimeNG Dec 11, 2024
@cetincakiroglu cetincakiroglu self-assigned this Dec 11, 2024
@mehmetcetin01140 mehmetcetin01140 modified the milestones: 18.0.1, 19.0.1 Dec 17, 2024
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Dec 18, 2024
@mertsincan mertsincan modified the milestones: 19.0.1, 19.0.0.Final, 18.0.1 Dec 18, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in PrimeNG Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
Status: Done
Development

No branches or pull requests

4 participants