-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[POM-94] 가게 전화번호 삭제 기능 추가 #32
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -57,7 +57,7 @@ public String getBusinessNumber() { | |
return requiredStoreInfo.getBusinessNumber(); | ||
} | ||
|
||
public Store afterRegisterPhoneNumber(String phoneNumber) { | ||
public Store retrieveStoreAfterRegisteringPhoneNumber(String phoneNumber) { | ||
return Store.builder() | ||
.id(this.id) | ||
.requiredStoreInfo(this.requiredStoreInfo) | ||
|
@@ -67,12 +67,22 @@ public Store afterRegisterPhoneNumber(String phoneNumber) { | |
.build(); | ||
} | ||
|
||
public Store retrieveStoreAfterDeletingPhoneNumber() { | ||
return Store.builder() | ||
.id(this.id) | ||
.requiredStoreInfo(this.requiredStoreInfo) | ||
.info(this.info) | ||
.tel(new PhoneNumber()) | ||
.ownerId(this.ownerId) | ||
.build(); | ||
} | ||
|
||
public Long getId() { | ||
return id; | ||
} | ||
|
||
public String getTel() { | ||
return tel.getTel(); | ||
public PhoneNumber getPhoneNumber() { | ||
return tel; | ||
Comment on lines
+84
to
+85
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 지금처럼 쓰실거면 tel의 getter니까 getTel 로 메소드 이름을 지어도 괜찮을 것 같아요 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. tel이 db에서는 사용해도 괜찮은데 뭔가 어플리케이션단에서는 쓰기 좀 그래서 PhoneNumber라 이름을 지었어요 |
||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메소드명에 retrieveStoreAfter가 필요한가요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
메서드 명을 어떻게 작성하는게 좋을까요?
단순히 register만 하는게 아니라 return type이 Store라서.. 이럴 경우 어떻게 메서드 명을 작성하는게 좋은지 저도 궁금하긴 하네요