[POM-94] 가게 전화번호 삭제 기능 추가 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juno-junho
requested review from
choi5798,
hyeon-z,
Juhongseok,
beomukim and
ddongpuri
beomukim
approved these changes
Sep 14, 2023
| @@ -57,7 +57,7 @@ public String getBusinessNumber() { | |||
| return requiredStoreInfo.getBusinessNumber(); | |||
| } | |||
|
|
|||
| public Store afterRegisterPhoneNumber(String phoneNumber) { | |||
| public Store retrieveStoreAfterRegisteringPhoneNumber(String phoneNumber) { | |||
There was a problem hiding this comment.
메소드명에 retrieveStoreAfter가 필요한가요?
There was a problem hiding this comment.
메서드 명을 어떻게 작성하는게 좋을까요?
단순히 register만 하는게 아니라 return type이 Store라서.. 이럴 경우 어떻게 메서드 명을 작성하는게 좋은지 저도 궁금하긴 하네요
choi5798
approved these changes
Sep 14, 2023
Comment on lines
+84
to
+85
| public PhoneNumber getPhoneNumber() { | ||
| return tel; |
There was a problem hiding this comment.
지금처럼 쓰실거면 tel의 getter니까 getTel 로 메소드 이름을 지어도 괜찮을 것 같아요
There was a problem hiding this comment.
tel이 db에서는 사용해도 괜찮은데 뭔가 어플리케이션단에서는 쓰기 좀 그래서 PhoneNumber라 이름을 지었어요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 설명