Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove strip-comments dependency #1066

Merged
merged 6 commits into from
Nov 19, 2024
Merged

Remove strip-comments dependency #1066

merged 6 commits into from
Nov 19, 2024

Conversation

Janther
Copy link
Contributor

@Janther Janther commented Nov 14, 2024

This one is a trimmed down PR #1063.
It's cleaner and more straight forward but also not being as aggressive.

The error we throw if presented with the weird pragmas is "Couldn't infer any version from the ranges in the pragmas.".

@Janther Janther requested a review from fvictorio November 15, 2024 00:04
Copy link
Member

@fvictorio fvictorio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit adding the filename to the error message. If you are ok with that, feel free to merge.

@Janther
Copy link
Contributor Author

Janther commented Nov 19, 2024

just added the case where there is no filepath. Also passing the options object as the changes I'm working on will use that and doesn't affect the current implementation

@Janther Janther merged commit 2bf85b9 into v2 Nov 19, 2024
7 checks passed
@Janther Janther deleted the remove-strip-comments branch November 19, 2024 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants