removing strip-comments and using prettier to clean pragma versions #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattiaerre
approved these changes
Nov 7, 2024
| parser: 'slangPragma' | ||
| }; | ||
|
|
||
| const query = Query.parse( |
There was a problem hiding this comment.
I noticed you moved query out of the tryToCollectPragmas function, but you only use it there; should we move it back to its original location?
There was a problem hiding this comment.
this way the query is computed only once and not every time it tryToCollectPragmas is called
Co-authored-by: Mattia Richetto <[email protected]>
Janther
force-pushed
the
prettier-for-pragma-version
branch
from
f2b6050 to
a167be2
Compare
|
I think I'd rather not support very weird pragma versions, like the one in the new test, and rather check that we throw a decent error when that happens (throw "couldn't parse version pragma in file " and crash). |
|
I made a new PR I had prepared if this one was too ambitious and complicated maintenance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aware this might be an overkill but the possible issue is really difficult to solve with other means (see tests).
I have a different approach to get rid of the
strip-commentsdependencies if this gets rejected.