Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add offline url validation when auth type is offline #49

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Add offline url validation when auth type is offline #49

merged 2 commits into from
Aug 31, 2020

Conversation

mehdy
Copy link
Collaborator

@mehdy mehdy commented Aug 27, 2020

Fixes #36

preslavmihaylov
preslavmihaylov reviewed Aug 28, 2020
View reviewed changes
testing/test_configs/invalid_offline_url.yaml
issue_tracker: JIRA
auth:
type: offline
offline_url: INVALID_URL
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Could you also add a test for when auth type is offline & offline_url is completely missing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is done.

@preslavmihaylov preslavmihaylov merged commit 30cd6ad into preslavmihaylov:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preslavmihaylov preslavmihaylov preslavmihaylov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Return error when no offline_url is specified with auth type offline
2 participants
@mehdy @preslavmihaylov