Add offline url validation when auth type is offline (#49)

* Add offline url validation for offline auth type Signed-off-by: Mehdy Khoshnoody <[email protected]> * Add tests for offline url validation Signed-off-by: Mehdy Khoshnoody <[email protected]>
preslavmihaylov · Aug 31, 2020 · 30cd6ad · 30cd6ad
1 parent b109a2b
commit 30cd6ad
Show file tree

Hide file tree

Showing 4 changed files with 44 additions and 0 deletions.
diff --git a/config/config.go b/config/config.go
@@ -3,6 +3,7 @@ package config
 import (
 	"fmt"
 	"io/ioutil"
+	"net/url"
 	"os"
 	"regexp"
 	"strings"
@@ -82,6 +83,10 @@ func (l *Local) Validate() []error {
 		errors = append(errors, err)
 	}
 
+	if err := l.validateAuthOfflineURL(); err != nil {
+		errors = append(errors, err)
+	}
+
 	return errors
 }
 
@@ -95,6 +100,14 @@ func (l *Local) validateIssueTracker() error {
 		l.IssueTracker, validIssueTrackers)
 }
 
+func (l *Local) validateAuthOfflineURL() error {
+	if _, err := url.ParseRequestURI(l.Auth.OfflineURL); l.Auth.Type == AuthTypeOffline && err != nil {
+		return fmt.Errorf("invalid offline URL: %q", l.Auth.OfflineURL)
+	}
+
+	return nil
+}
+
 func exists(filepath string) bool {
 	info, err := os.Stat(filepath)
 	if os.IsNotExist(err) {

diff --git a/testing/test_configs/invalid_offline_url.yaml b/testing/test_configs/invalid_offline_url.yaml
@@ -0,0 +1,5 @@
+origin: http://127.0.0.1:51596
+issue_tracker: JIRA
+auth: 
+  type: offline
+  offline_url: INVALID_URL
diff --git a/testing/test_configs/non_existent_offline_url.yaml b/testing/test_configs/non_existent_offline_url.yaml
@@ -0,0 +1,4 @@
+origin: http://127.0.0.1:51596
+issue_tracker: JIRA
+auth: 
+  type: offline
diff --git a/testing/todocheck_test.go b/testing/todocheck_test.go
@@ -330,6 +330,28 @@ func TestInvalidIssueTracker(t *testing.T) {
 	}
 }
 
+func TestInvalidOfflineURL(t *testing.T) {
+	err := scenariobuilder.NewScenario().
+		WithBinary("../todocheck").
+		WithConfig("./test_configs/invalid_offline_url.yaml").
+		ExpectExecutionError().
+		Run()
+	if err != nil {
+		t.Errorf("%s", err)
+	}
+}
+
+func TestNonExistentOfflineURL(t *testing.T) {
+	err := scenariobuilder.NewScenario().
+		WithBinary("../todocheck").
+		WithConfig("./test_configs/non_existent_offline_url.yaml").
+		ExpectExecutionError().
+		Run()
+	if err != nil {
+		t.Errorf("%s", err)
+	}
+}
+
 func TestTraversingNonExistentDirectory(t *testing.T) {
 	err := scenariobuilder.NewScenario().
 		WithBinary("../todocheck").