Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to import dataset asset with no 'targets' field like filter divider #321

Merged
merged 8 commits into from
Oct 25, 2024
Merged

Adding ability to import dataset asset with no 'targets' field like filter divider #321

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1024baa
targets missing keyword
swish-gweisang Oct 14, 2024
dd67af1
importing assets with no 'targets' field, i.e. filter divider
swish-gweisang Oct 15, 2024
897caa0
cleaning up debugging code
swish-gweisang Oct 14, 2024
4fe576c
Adding back fix to import dataset asset with no 'targets' field
swish-gweisang Oct 16, 2024
0175ce4
Adding test and fixing default type
swish-gweisang Oct 24, 2024
36b4e4e
Making CI happy
Vitor-Avila Oct 25, 2024
0319864
Merge branch 'main' into fix/gw-import
Vitor-Avila Oct 25, 2024
db91d11
Fixing test
Vitor-Avila Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/preset_cli/cli/superset/sync/native/command.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,6 @@ def native( # pylint: disable=too-many-locals, too-many-arguments, too-many-bra
url = URL(ctx.obj["INSTANCE"])
client = SupersetClient(url, auth)
root = Path(directory)

base_url = URL(external_url_prefix) if external_url_prefix else None

# collecting existing database UUIDs so we know if we're creating or updating
Expand Down Expand Up @@ -326,7 +325,7 @@ def get_dataset_filter_uuids(config: AssetConfig) -> Set[str]:
"""
dataset_uuids = set()
for filter_config in config["metadata"].get("native_filter_configuration", []):
for target in filter_config["targets"]:
for target in filter_config.get("targets", dict()):
Vitor-Avila marked this conversation as resolved.
Show resolved Hide resolved
if uuid := target.get("datasetUuid"):
if uuid not in dataset_uuids:
dataset_uuids.add(uuid)
Expand Down
Loading