Adding ability to import dataset asset with no 'targets' field like filter divider

[swish-gweisang]

Currently, importing a dashboard with filter dividers will break as the import of the dataset filters expects a 'targets' field in the yaml config file. However, a filter divider, which has no target, can still be imported if the 'targets' field defaults to an empty dict.

[CLAassistant]

All committers have signed the CLA.

[Vitor-Avila]

Hey @swish-gweisang,

Thank you for catching this issue and also for working on a solution. It seems the latest commit removed your actual changes. Are you looking to move forward with this contribution? Happy to review the PR 🙌 🙏

[swish-gweisang]

@Vitor-Avila Thanks! My bad. Added the fix back in ...

[Vitor-Avila]

Hey @swish-gweisang,

I left a comment in the PR. Also, could you add a test with a dashboard that would have a divider in its configuration? Or alternatively modify the dashboard mock used by tests that cover this flow to have a divider? This way we can prevent a regression.

Thank you!

[Vitor-Avila]

Hey @swish-gweisang,

I'm wondering if you had a chance to check my last message. I'm looking forward to push this one across the finish line. 🙌

Thank you!

[Vitor-Avila]

thanks for adding the test @swish-gweisang! 🙏 I think we're only missing to resolve the conflicts and I can restart CI. Are you able to resolve the conflicts or would you like me to handle these? thanks!

[swish-gweisang]

Could you resolve these conflicts? Best --- Guillaume Weisang, Ph. D. Trading Analytics Manager ***@***.*** 

…

On Oct 25, 2024, at 11:37 AM, Vitor Avila ***@***.***> wrote: thanks for adding the test @swish-gweisang <https://github.com/swish-gweisang>! 🙏 I think we're only missing to resolve the conflicts and I can restart CI. Are you able to resolve the conflicts or would you like me to handle these? thanks! — Reply to this email directly, view it on GitHub <#321 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/BBPNS4NYZPINOTPDS53JWZLZ5JQTVAVCNFSM6AAAAABP7H2M5KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZYGE2DSMZWGY>. You are receiving this because you were mentioned.

[Vitor-Avila]

LGTM!